Skip to content

tools: update ESLint to 5.14.1 - #26190

Merged
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:eslint
Feb 20, 2019
Merged

tools: update ESLint to 5.14.1#26190
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:eslint

Conversation

@cjihrig

Copy link
Copy Markdown
Contributor

Update ESLint to 5.14.1

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the tools Issues and PRs related to the tools directory. label Feb 18, 2019
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@danbev

danbev commented Feb 19, 2019

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/20877/

EDIT(cjihrig): CI was green.

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 20, 2019
Update ESLint to 5.14.1
PR-URL: nodejs#26190
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@cjihrig
cjihrig merged commit 14c089b into nodejs:masterFeb 20, 2019
@cjihrig
cjihrig deleted the eslint branch February 20, 2019 17:27
addaleax pushed a commit that referenced this pull request Feb 21, 2019
Update ESLint to 5.14.1
PR-URL: #26190
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeARBridgeAR mentioned this pull request Feb 26, 2019
rvagg pushed a commit that referenced this pull request Feb 28, 2019
Update ESLint to 5.14.1
PR-URL: #26190
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.toolsIssues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@cjihrig@nodejs-github-bot@danbev@refack@Trott@richardlau@BridgeAR