Skip to content

src: remove unimplemented method in class SSLWrap - #26203

Closed
gengjiawen wants to merge 1 commit into
nodejs:masterfrom
gengjiawen:clean_node_crypto
Closed

src: remove unimplemented method in class SSLWrap#26203
gengjiawen wants to merge 1 commit into
nodejs:masterfrom
gengjiawen:clean_node_crypto

Conversation

@gengjiawen

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Feb 19, 2019
@BridgeAR

Copy link
Copy Markdown
Member

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 20, 2019
@danbev

danbev commented Feb 22, 2019

Copy link
Copy Markdown
Contributor

Re-run of failing node-test-commit-linux-containered (✔️)

@danbev

Copy link
Copy Markdown
Contributor

Landed in a1a01d3.

@danbevdanbev closed this Feb 27, 2019
danbev pushed a commit that referenced this pull request Feb 27, 2019
PR-URL: #26203
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
addaleax pushed a commit that referenced this pull request Mar 1, 2019
PR-URL: #26203
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@BridgeARBridgeAR mentioned this pull request Mar 4, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.cryptoIssues and PRs related to the crypto subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@gengjiawen@BridgeAR@danbev@jasnell@addaleax@cjihrig@tniessen@nodejs-github-bot