Skip to content

src: remove already elevated Isolate namespace - #26294

Closed
juanarbol wants to merge 1 commit into
nodejs:masterfrom
juanarbol:cc-elevate-isolate
Closed

src: remove already elevated Isolate namespace#26294
juanarbol wants to merge 1 commit into
nodejs:masterfrom
juanarbol:cc-elevate-isolate

Conversation

@juanarbol

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 24, 2019
@addaleax

Copy link
Copy Markdown
Member

@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 2, 2019
@antsmartian

Copy link
Copy Markdown
Contributor

Landed in 1d97374 🎉 Thanks @juanarbol 👍

antsmartian pushed a commit that referenced this pull request Mar 3, 2019
PR-URL: #26294
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR pushed a commit that referenced this pull request Mar 4, 2019
PR-URL: #26294
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeARBridgeAR mentioned this pull request Mar 4, 2019
BethGriggs pushed a commit that referenced this pull request Apr 16, 2019
PR-URL: #26294
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggsBethGriggs mentioned this pull request May 1, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@juanarbol@addaleax@antsmartian@jasnell@lpinca@targos@cjihrig@nodejs-github-bot