Skip to content

src: remove dead inspector code - #26295

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:inspector-dead-code
Closed

src: remove dead inspector code#26295
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:inspector-dead-code

Conversation

@addaleax

@addaleaxaddaleax commented Feb 24, 2019

Copy link
Copy Markdown
Member

This was overlooked in c583245.

Refs: #26137

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Feb 24, 2019

Copy link
Copy Markdown
Collaborator

@addaleax sadly an error occured when I tried to trigger a build :(

@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 24, 2019
@addaleaxaddaleax added the inspector Issues and PRs related to the V8 inspector protocol label Feb 24, 2019
@addaleax

addaleax commented Feb 28, 2019

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/21067/

@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 28, 2019
@addaleax

addaleax commented Mar 1, 2019

Copy link
Copy Markdown
MemberAuthor

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/21080/

@addaleax

addaleax commented Mar 1, 2019

Copy link
Copy Markdown
MemberAuthor

Landed in b0b370c

@addaleaxaddaleax closed this Mar 1, 2019
@addaleax
addaleax deleted the inspector-dead-code branch March 1, 2019 20:48
addaleax added a commit that referenced this pull request Mar 1, 2019
@addaleax
src: remove dead inspector code
b0b370c
This was overlooked in c583245.
Refs: #26137
PR-URL: #26295
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
addaleax added a commit that referenced this pull request Mar 1, 2019
@addaleax
src: remove dead inspector code
30f0a3b
This was overlooked in c583245.
Refs: #26137
PR-URL: #26295
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@BridgeARBridgeAR mentioned this pull request Mar 4, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes
@tniessentniessentniessen approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.inspectorIssues and PRs related to the V8 inspector protocol

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@addaleax@nodejs-github-bot@jasnell@cjihrig@tniessen