Uh oh!
There was an error while loading. Please reload this page.
test: remove usage of process.binding() - #26304
Closed
addaleax wants to merge 2 commits into
Closed
Conversation
nodejs-github-bot
commented
Feb 25, 2019
Collaborator
@addaleax sadly an error occured when I tried to trigger a build :( |
alejunco
approved these changes
Feb 25, 2019
Puzzle9900
approved these changes
Feb 25, 2019
asarmiento13315
approved these changes
Feb 25, 2019
zydev-gh
approved these changes
Feb 25, 2019
jasnell
approved these changes
Feb 26, 2019
JungMinu
approved these changes
Feb 26, 2019
BridgeAR
approved these changes
Feb 26, 2019
BridgeAR
left a comment
Member
There was a problem hiding this comment.
LGTM. AFAIK there is a conflicting PR open for a while.
devsnek
approved these changes
Feb 26, 2019
BridgeAR
commented
Feb 26, 2019
Member
Refs: #24952 |
thefourtheye
approved these changes
Feb 26, 2019
cjihrig
approved these changes
Feb 26, 2019
addaleax
commented
Feb 26, 2019
MemberAuthor
@BridgeAR Yeah, thanks. I’ll try to land that one first. |
addaleaxforce-pushed
the
no-process-binding-tests
branch
from
March 7, 2019 08:29
c706a3b to
9a9b038ComparePrefer `internalBinding` or other equivalents over `process.binding()` (except in tests checking `process.binding()` itself).
addaleaxforce-pushed
the
no-process-binding-tests
branch
from
March 7, 2019 08:31
9a9b038 to
8c99173Compareaddaleax
commented
Mar 7, 2019
MemberAuthor
Rebased, new CI: https://ci.nodejs.org/job/node-test-pull-request/21296/ |
BridgeAR
approved these changes
Mar 7, 2019
addaleaxforce-pushed
the
no-process-binding-tests
branch
from
March 7, 2019 08:43
c12a713 to
4e3990bCompareaddaleax
commented
Mar 7, 2019
MemberAuthor
Fixed one more error that just (?) showed up, CI: https://ci.nodejs.org/job/node-test-pull-request/21297/ |
addaleax
commented
Mar 7, 2019
MemberAuthor
addaleax
commented
Mar 7, 2019
MemberAuthor
Landed in aec3447 |
pullBot
pushed a commit
to SimenB/node
that referenced
this pull request
Mar 7, 2019
Prefer `internalBinding` or other equivalents over `process.binding()` (except in tests checking `process.binding()` itself). PR-URL: nodejs#26304 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 12, 2019
Prefer `internalBinding` or other equivalents over `process.binding()` (except in tests checking `process.binding()` itself). PR-URL: nodejs#26304 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR pushed a commit
that referenced
this pull request
Mar 14, 2019
Prefer `internalBinding` or other equivalents over `process.binding()` (except in tests checking `process.binding()` itself). PR-URL: #26304 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This paves the way for adding
--pending-deprecationsupport forprocess.binding(), see e.g. addaleax/node@8e6577d (which could land after this, but would likely be semver-major).Prefer
internalBindingor other equivalents overprocess.binding()(except in tests checking
process.binding()itself).Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes