Skip to content

src: fix typo in callback.cc - #26337

Closed
gengjiawen wants to merge 1 commit into
nodejs:masterfrom
gengjiawen:callback_typo
Closed

src: fix typo in callback.cc#26337
gengjiawen wants to merge 1 commit into
nodejs:masterfrom
gengjiawen:callback_typo

Conversation

@gengjiawen

@gengjiawengengjiawen commented Feb 27, 2019

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 27, 2019
@addaleax

addaleax commented Mar 2, 2019

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/21124/

@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 2, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 4, 2019
@gengjiawen@BridgeAR
src: fix typo in callback.cc
5e23bac
PR-URL: nodejs#26337
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR

BridgeAR commented Mar 4, 2019

Copy link
Copy Markdown
Member

Landed in 5e23bac 🎉

@BridgeARBridgeAR closed this Mar 4, 2019
@gengjiawen
gengjiawen deleted the callback_typo branch March 4, 2019 02:26
BridgeAR pushed a commit that referenced this pull request Mar 4, 2019
@gengjiawen@BridgeAR
src: fix typo in callback.cc
fc49173
PR-URL: #26337
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeARBridgeAR mentioned this pull request Mar 4, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 5, 2019
@gengjiawen@BridgeAR
src: fix typo in callback.cc
fc9ba36
PR-URL: #26337
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@richardlaurichardlaurichardlau approved these changes
@BridgeARBridgeARBridgeAR approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@gengjiawen@addaleax@BridgeAR@jasnell@lpinca@richardlau@nodejs-github-bot