Uh oh!
There was an error while loading. Please reload this page.
doc,lib,test: rename node-report to report - #26371
Merged
Merged
Conversation
richardlau
approved these changes
Mar 1, 2019
Trott
approved these changes
Mar 1, 2019
JungMinu
approved these changes
Mar 1, 2019
jasnell
approved these changes
Mar 1, 2019
This commit renames the "node-report" test suite to "report" in order to begin differentiating core's diagnostic reporting from the original node-report module on npm PR-URL: nodejs#26371 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This commit completes the renaming of node-report to report in order to better differentiate core's reporting from the node-report npm module. PR-URL: nodejs#26371 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: James M Snell <jasnell@gmail.com>
cjihrig
commented
Mar 3, 2019
ContributorAuthor
cjihrig
commented
Mar 3, 2019
ContributorAuthor
Landed in 060af32...f9cd5e3 |
BridgeAR pushed a commit
that referenced
this pull request
Mar 4, 2019
This commit renames the "node-report" test suite to "report" in order to begin differentiating core's diagnostic reporting from the original node-report module on npm PR-URL: #26371 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR pushed a commit
that referenced
this pull request
Mar 4, 2019
This commit completes the renaming of node-report to report in order to better differentiate core's reporting from the node-report npm module. PR-URL: #26371 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames "node-report" to "report" throughout the codebase. The motivation is to begin making the distinction stronger between core's diagnostic reporting and the original
node-reportmodule on npm.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes