src: refactor `Environment::GetCurrent(isolate)` usage by addaleax · Pull Request #26376 · nodejs/node

addaleax · 2019-03-01T15:49:07Z

src: refactor `Environment::GetCurrent(isolate)` usage

Do not require an explicit HandleScope, or the ability to create
one, when using Environment::GetCurrent().

isolate->InContext() is used as an indicator that it is probably
okay to create a HandleScope, see also the short discussion in
#25775 (review).

src: prefer to get `Environment` from `Context`

We explicitly store the context anyway, and can skip the
extra steps introduced in Environment::GetCurrent().

src: allow running tasks without `Environment`

There is no real reason to assume that V8 tasks would have
to run in a Node.js Context.

src: forbid handle allocations from Platform tasks

Platform tasks should have their own handle scopes, rather than
leak into outer ones.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Do not require an explicit `HandleScope`, or the ability to create one, when using `Environment::GetCurrent()`. `isolate->InContext()` is used as an indicator that it is probably okay to create a `HandleScope`, see also the short discussion in nodejs#25775 (review).

We explicitly store the context anyway, and can skip the extra steps introduced in `Environment::GetCurrent()`.

There is no real reason to assume that V8 tasks would have to run in a Node.js `Context`.

Platform tasks should have their own handle scopes, rather than leak into outer ones.

nodejs-github-bot · 2019-03-01T15:49:10Z

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2728/pipeline

addaleax · 2019-03-01T16:12:16Z

CI: https://ci.nodejs.org/job/node-test-pull-request/21098/

addaleax · 2019-03-04T23:00:59Z

CI: https://ci.nodejs.org/job/node-test-pull-request/21199/

addaleax · 2019-03-05T21:50:04Z

Landed in cc4e8e0...820ae61

Do not require an explicit `HandleScope`, or the ability to create one, when using `Environment::GetCurrent()`. `isolate->InContext()` is used as an indicator that it is probably okay to create a `HandleScope`, see also the short discussion in #25775 (review). PR-URL: #26376 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

We explicitly store the context anyway, and can skip the extra steps introduced in `Environment::GetCurrent()`. PR-URL: #26376 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

There is no real reason to assume that V8 tasks would have to run in a Node.js `Context`. PR-URL: #26376 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Platform tasks should have their own handle scopes, rather than leak into outer ones. PR-URL: #26376 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Do not require an explicit `HandleScope`, or the ability to create one, when using `Environment::GetCurrent()`. `isolate->InContext()` is used as an indicator that it is probably okay to create a `HandleScope`, see also the short discussion in nodejs#25775 (review). PR-URL: nodejs#26376 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

We explicitly store the context anyway, and can skip the extra steps introduced in `Environment::GetCurrent()`. PR-URL: nodejs#26376 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

There is no real reason to assume that V8 tasks would have to run in a Node.js `Context`. PR-URL: nodejs#26376 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Platform tasks should have their own handle scopes, rather than leak into outer ones. PR-URL: nodejs#26376 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax added 4 commits March 1, 2019 16:32

src: prefer to get Environment from Context
d85419d
We explicitly store the context anyway, and can skip the extra steps introduced in `Environment::GetCurrent()`.

src: allow running tasks without Environment
322041b
There is no real reason to assume that V8 tasks would have to run in a Node.js `Context`.

src: forbid handle allocations from Platform tasks
6b766af
Platform tasks should have their own handle scopes, rather than leak into outer ones.

addaleax requested a review from gireeshpunathil March 1, 2019 15:49

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Mar 1, 2019

gireeshpunathil reviewed Mar 1, 2019
View reviewed changes

Comment threadsrc/env-inl.h

gireeshpunathil approved these changes Mar 1, 2019
View reviewed changes

ZYSzys reviewed Mar 1, 2019
View reviewed changes

Comment threadsrc/node_platform.cc

ZYSzys approved these changes Mar 1, 2019
View reviewed changes

bnoordhuis approved these changes Mar 1, 2019
View reviewed changes

Comment threadsrc/node_perf.cc Outdated

fixup! src: prefer to get Environment from Context
7f99bbb

cjihrig approved these changes Mar 1, 2019
View reviewed changes

addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 4, 2019

jasnell approved these changes Mar 4, 2019
View reviewed changes

addaleax closed this Mar 5, 2019

addaleax deleted the embedding-env-getcurrent branch March 5, 2019 21:50

BridgeAR mentioned this pull request Mar 13, 2019
2019-03-14, Version 11.12.0 (Current) #26644
Merged

Navigation Menu

Uh oh!

Uh oh!

src: refactor `Environment::GetCurrent(isolate)` usage - #26376

src: refactor `Environment::GetCurrent(isolate)` usage#26376
addaleax wants to merge 5 commits into
nodejs:masterfrom
addaleax:embedding-env-getcurrent

addaleax commented Mar 1, 2019

Uh oh!

nodejs-github-bot commented Mar 1, 2019

Uh oh!

Uh oh!

addaleax commented Mar 1, 2019

Uh oh!

Uh oh!

Uh oh!

addaleax commented Mar 4, 2019

Uh oh!

addaleax commented Mar 5, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Uh oh!

Conversation

addaleax commented Mar 1, 2019

src: refactor Environment::GetCurrent(isolate) usage

src: prefer to get Environment from Context

src: allow running tasks without Environment

src: forbid handle allocations from Platform tasks

Checklist

Uh oh!

nodejs-github-bot commented Mar 1, 2019

Uh oh!

Uh oh!

addaleax commented Mar 1, 2019

Uh oh!

Uh oh!

Uh oh!

addaleax commented Mar 4, 2019

Uh oh!

addaleax commented Mar 5, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

src: refactor `Environment::GetCurrent(isolate)` usage

src: prefer to get `Environment` from `Context`

src: allow running tasks without `Environment`