doc: update AUTHORS list by addaleax · Pull Request #26383 · nodejs/node

addaleax · 2019-03-01T21:52:22Z

This was last updated in September, so I think it’s time. :)

nodejs-github-bot · 2019-03-01T21:52:24Z

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2733/pipeline

addaleax · 2019-03-01T21:55:46Z

@uttampawar You have committed with two different email addresses – which do you prefer to have listed here?

gengjiawen · 2019-03-01T23:50:20Z

is / a redundant here ?

This is taken from the git log, from the Author: field – @Naturalclar Which name should we use here? Or should we keep the /?

ChALkeR · 2019-03-02T00:24:11Z

I think this is @mcollina?

This was happening because we didn’t have support for .mailmap entries for Co-authored-by: or Author: tags that were manually added to the commit message.
8f2bb03609c3b4406f80dc4f71d91bdd27ac73f8 should remedy that.

gengjiawen · 2019-03-02T13:23:02Z

Back then I am young and simple, now I think my email address is silly 😭

@gengjiawen You can always change it for new commits with git config --global user.email foo@bar.com, and you can always choose one for the AUTHORS file if you want? :)
(Also, it’s not silly. 🙂)

Thanks. Maybe later :)

Support `.mailmap` for manually added `Author:` and `Co-authored-by:` tags.

addaleax · 2019-03-04T23:53:46Z

@BridgeAR Done, applied your suggestions in 68921c0

addaleax · 2019-03-04T23:55:25Z

-David Mark Clements <david.clements@nearform.com> davidmarkclements <huperekchuno@googlemail.com>
+David Mark Clements <david.clements@nearform.com>
+David Mark Clements <david.clements@nearform.com> <huperekchuno@googlemail.com>
+David Mark Clements <david.clements@nearform.com> <david.mark.clements@gmail.com>


@davidmarkclements Just confirming, since you’ve been freshly listed with a third email address thanks to b1ef279 – the NearForm one is still the one you use for AUTHORS?

BridgeAR

RSLGTM

ChALkeR · 2019-03-05T02:19:15Z

@cclauss, this issue log shows that I deleted your comment here: #26383 (comment):

I wanted to apologise for that, that comment deletion was not intentional, and I just recently noticed it.

I don't remember deleting a comment here (on a purpose or not), it must have been accidental, most likely while I was commenting on this issue from my phone.

Unfortunately, I do not have the means of restoring a deleted comment or checking what exactly was in that comment (GitHub does not provide that afaik). The only way that I know how it could be restored is if you re-post it from your side.

I really hope that nothing was missed, but in any case — please feel free to restore that comment if you want to.

Sorry again 😞 .

Trott · 2019-03-05T02:30:31Z

Unfortunately, I do not have the means of restoring a deleted comment or checking what exactly was in that comment

Someone who receives email notifications of comments on this issue might have the content.

gireeshpunathil · 2019-03-05T02:41:36Z

this is what I have in mailbox matching to that day and time - the accidentally deleted comment, for the record:

Subject:	Re: [nodejs/node] doc: update AUTHORS list (#26383)
From:	cclauss
To:	nodejs/node, Subscribed
Date:	03/02/2019 07:13 PM
@cclauss commented on this pull request.
In .mailmap:
> @@ -72,6 +73,8 @@ Chew Choon Keat <choonkeat@gmail.com>
Chris Andrews <cpandrews8@gmail.com> cpandrews8 <cpandrews8@gmail.com>
Chris Johnson <chris.s.johnson4@gmail.com>
Chris Young <chris.young@tinder.com> <chris.young@gotinder.com>
+Christian Clauss <cclauss@me.com>
We can keep line 76 and delete line 77.

addaleax · 2019-03-05T16:14:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/21218/

Support `.mailmap` for manually added `Author:` and `Co-authored-by:` tags. PR-URL: nodejs#26383 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

PR-URL: nodejs#26383 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

BridgeAR · 2019-03-05T23:07:36Z

Landed in 713046d, 6e3b216 🎉

Support `.mailmap` for manually added `Author:` and `Co-authored-by:` tags. PR-URL: nodejs#26383 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

PR-URL: nodejs#26383 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

addaleax added the meta Issues and PRs related to the general management of the project. label Mar 1, 2019

addaleax commented Mar 1, 2019
View reviewed changes

gengjiawen reviewed Mar 1, 2019
View reviewed changes

ChALkeR reviewed Mar 2, 2019
View reviewed changes

Comment threadAUTHORS Outdated

ChALkeR reviewed Mar 2, 2019
View reviewed changes

Comment threadAUTHORS Outdated

addaleax force-pushed the update-authors branch from fe28b86 to c967521Compare March 2, 2019 11:38

gengjiawen reviewed Mar 2, 2019
View reviewed changes

nodejs deleted a comment from cclauss Mar 2, 2019

ChALkeR reviewed Mar 2, 2019
View reviewed changes

Comment thread.mailmap Outdated

BridgeAR reviewed Mar 3, 2019
View reviewed changes

Comment threadtools/update-authors.js Outdated
Comment threadtools/update-authors.js Outdated

tniessen approved these changes Mar 4, 2019
View reviewed changes

addaleax added 6 commits March 5, 2019 00:51

tools: add mailmap support for Co-authored-by tags
159554c
Support `.mailmap` for manually added `Author:` and `Co-authored-by:` tags.

doc: update AUTHORS list
ed6167c

fixup! doc: update AUTHORS list
5ed8b19

fixup! tools: add mailmap support for Co-authored-by tags
299b502

fixup! tools: add mailmap support for Co-authored-by tags
68921c0

fixup! doc: update AUTHORS list
0aeb028

addaleax force-pushed the update-authors branch from d4cd064 to 0aeb028Compare March 4, 2019 23:53

addaleax commented Mar 4, 2019
View reviewed changes

BridgeAR approved these changes Mar 4, 2019
View reviewed changes

benjamingr approved these changes Mar 5, 2019
View reviewed changes

richardlau reviewed Mar 5, 2019
View reviewed changes

Comment threadAUTHORS Outdated

fixup! doc: update AUTHORS list
40f1c47

addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 5, 2019

BridgeAR closed this Mar 5, 2019

BridgeAR mentioned this pull request Mar 13, 2019
2019-03-14, Version 11.12.0 (Current) #26644
Merged

Uh oh!

Uh oh!

Conversation

addaleax commented Mar 1, 2019

Uh oh!

nodejs-github-bot commented Mar 1, 2019

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

addaleax commented Mar 4, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BridgeAR left a comment

Choose a reason for hiding this comment

Uh oh!

ChALkeR commented Mar 5, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Trott commented Mar 5, 2019

Uh oh!

gireeshpunathil commented Mar 5, 2019

Uh oh!

Uh oh!

addaleax commented Mar 5, 2019

Uh oh!

BridgeAR commented Mar 5, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

ChALkeR commented Mar 5, 2019•
edited
Loading