Skip to content

tools: update ESLint to 5.15.0 - #26391

Merged
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:eslint
Mar 4, 2019
Merged

tools: update ESLint to 5.15.0#26391
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:eslint

Conversation

@cjihrig

Copy link
Copy Markdown
Contributor

Update ESLint to 5.15.0

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-botnodejs-github-bot added the tools Issues and PRs related to the tools directory. label Mar 2, 2019

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 2, 2019
Update ESLint to 5.15.0
PR-URL: nodejs#26391
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@cjihrig
cjihrig merged commit 17b7fa7 into nodejs:masterMar 4, 2019
@cjihrig
cjihrig deleted the eslint branch March 4, 2019 03:07
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
Update ESLint to 5.15.0
PR-URL: nodejs#26391
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.toolsIssues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@cjihrig@nodejs-github-bot@Trott@BridgeAR@shisama