Skip to content

tools: update node-lint-md-cli-rollup lockfile - #26393

Closed
Trott wants to merge 2 commits into
nodejs:masterfrom
Trott:update-more-lock
Closed

tools: update node-lint-md-cli-rollup lockfile#26393
Trott wants to merge 2 commits into
nodejs:masterfrom
Trott:update-more-lock

Conversation

@Trott

@TrottTrott commented Mar 2, 2019

Copy link
Copy Markdown
Member

This includes an update for chownr from 1.0.1 to 1.1.1, which means a
fix for the issue described in
isaacs/chownr#14. While not a
user-facing issue and unlikely to be exploitable, it seems like a good idea to patch promptly anyway.

Also rebuild lint-md.js with the updated modules.

👍 here to fast-track.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Trott added 2 commits March 1, 2019 22:16
This includes an update for chownr from 1.0.1 to 1.1.1, which means a
fix for the issue described in
isaacs/chownr#14. While not a
user-facing issue, it seems like a good idea to patch promptly anyway.
Update lint-md.js from updated rollup modules.
@TrottTrott added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 2, 2019
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-botnodejs-github-bot added the tools Issues and PRs related to the tools directory. label Mar 2, 2019
@Trott

Trott commented Mar 2, 2019

Copy link
Copy Markdown
MemberAuthor

Changes to lint-md.js are a result of build process. That is not a file that gets manually edited. Might be slightly easier to review with whitespace changes hidden, although really it probably just gets rubber-stamp reviewed.
¯\(ツ)

@Trott

Trott commented Mar 3, 2019

Copy link
Copy Markdown
MemberAuthor

@nodejs/linting @refack

@BridgeARBridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 3, 2019

@refackrefack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@TrottTrott removed the fast-track PRs that do not need to wait for 48 hours to land. label Mar 4, 2019
@Trott

Trott commented Mar 4, 2019

Copy link
Copy Markdown
MemberAuthor

Landed in 17b7fa7...d3d79d9

@TrottTrott closed this Mar 4, 2019
Trott added a commit to Trott/io.js that referenced this pull request Mar 4, 2019
This includes an update for chownr from 1.0.1 to 1.1.1, which means a
fix for the issue described in
isaacs/chownr#14. While not a
user-facing issue, it seems like a good idea to patch promptly anyway.
PR-URL: nodejs#26393
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Trott added a commit to Trott/io.js that referenced this pull request Mar 4, 2019
Update lint-md.js from updated rollup modules.
PR-URL: nodejs#26393
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
This includes an update for chownr from 1.0.1 to 1.1.1, which means a
fix for the issue described in
isaacs/chownr#14. While not a
user-facing issue, it seems like a good idea to patch promptly anyway.
PR-URL: nodejs#26393
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
Update lint-md.js from updated rollup modules.
PR-URL: nodejs#26393
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@Trott
Trott deleted the update-more-lock branch January 13, 2022 22:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.toolsIssues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Trott@nodejs-github-bot@refack@BridgeAR