Skip to content

tools: add no-var lint rule for tools directory - #26398

Closed
shisama wants to merge 2 commits into
nodejs:masterfrom
shisama:no-var-for-tools
Closed

tools: add no-var lint rule for tools directory#26398
shisama wants to merge 2 commits into
nodejs:masterfrom
shisama:no-var-for-tools

Conversation

@shisama

@shisamashisama commented Mar 2, 2019

Copy link
Copy Markdown
Contributor
  • first commit is that var is replaced to let/const.
  • second commit is that no-var rule is added to tools/.eslintrc.yaml.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Mar 2, 2019

Copy link
Copy Markdown
Collaborator

@shisama build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2743/pipeline

@nodejs-github-botnodejs-github-bot added the tools Issues and PRs related to the tools directory. label Mar 2, 2019
@ChALkeR

ChALkeR commented Mar 2, 2019

Copy link
Copy Markdown
Member

How many errors does prefer-const give?

@refack

refack commented Mar 2, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

How many errors does prefer-const give?

🍩

P.S. it's because it's already active from parent scope

node/.eslintrc.js

Line 249 in b1ef279

'prefer-const': ['error',{ignoreReadBeforeAssign: true}],

refack
refack reviewed Mar 2, 2019
View reviewed changes
Comment threadtools/.eslintrc.yaml Outdated
@shisama

shisama commented Mar 3, 2019

Copy link
Copy Markdown
ContributorAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/21158/

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 3, 2019
@BridgeAR

BridgeAR commented Mar 5, 2019

Copy link
Copy Markdown
Member

@shisama this requires a rebase.

@BridgeARBridgeAR removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 5, 2019
@shisama

shisama commented Mar 6, 2019

Copy link
Copy Markdown
ContributorAuthor

rebase build: https://ci.nodejs.org/job/node-test-pull-request/21246/

@shisama

shisama commented Mar 6, 2019

Copy link
Copy Markdown
ContributorAuthor

@BridgeAR rebased this. Thank you.

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 6, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 6, 2019
Masashi Hirano@BridgeAR
tools: replace var to let/const
ce8f01c
PR-URL: nodejs#26398
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 6, 2019
shisama@BridgeAR
tools: add no-var lint rule for tools directory
70beb76
PR-URL: nodejs#26398
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR

BridgeAR commented Mar 6, 2019

Copy link
Copy Markdown
Member

Landed in ce8f01c, 70beb76 🎉

@BridgeARBridgeAR closed this Mar 6, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
Masashi Hirano@BridgeAR
tools: replace var to let/const
b3ecaaa
PR-URL: nodejs#26398
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
shisama@BridgeAR
tools: add no-var lint rule for tools directory
a8331fa
PR-URL: nodejs#26398
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeARBridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
Masashi Hirano@BridgeAR
tools: replace var to let/const
57198f2
PR-URL: #26398
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
shisama@BridgeAR
tools: add no-var lint rule for tools directory
0a1537e
PR-URL: #26398
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@shisama
shisama deleted the no-var-for-tools branch March 21, 2019 14:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChALkeRChALkeRChALkeR approved these changes
@cjihrigcjihrigcjihrig approved these changes
@gengjiawengengjiawengengjiawen approved these changes
@richardlaurichardlaurichardlau approved these changes
@BridgeARBridgeARBridgeAR approved these changes
+1 more reviewer
@refackrefackrefack approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@shisama@nodejs-github-bot@ChALkeR@refack@BridgeAR@cjihrig@gengjiawen@richardlau