Skip to content

doc: clarify http.Agent constructor options - #26412

Closed
lpinca wants to merge 1 commit into
nodejs:masterfrom
lpinca:gh-26357
Closed

doc: clarify http.Agent constructor options#26412
lpinca wants to merge 1 commit into
nodejs:masterfrom
lpinca:gh-26357

Conversation

@lpinca

@lpincalpinca commented Mar 3, 2019

Copy link
Copy Markdown
Member

Fixes: #26357

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Mar 3, 2019

Copy link
Copy Markdown
Collaborator

@lpinca build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2748/pipeline

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Mar 3, 2019
shisama
shisama reviewed Mar 3, 2019
View reviewed changes
Comment threaddoc/api/http.md Outdated
@BridgeAR
BridgeAR requested a review from mcollinaMarch 3, 2019 22:58
Trott
Trott reviewed Mar 4, 2019
View reviewed changes
Comment threaddoc/api/http.md Outdated
Trott
Trott reviewed Mar 4, 2019
View reviewed changes
Comment threaddoc/api/http.md Outdated
mcollina
mcollina approved these changes Mar 4, 2019
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BridgeAR

BridgeAR commented Mar 5, 2019

Copy link
Copy Markdown
Member

Lite-CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2762/

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 5, 2019
@BridgeAR

BridgeAR commented Mar 5, 2019

Copy link
Copy Markdown
Member

Landed in 8a291a8 🎉

@BridgeARBridgeAR closed this Mar 5, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 5, 2019
@lpinca@BridgeAR
doc: clarify http.Agent constructor options
8a291a8
PR-URL: nodejs#26412Fixes: nodejs#26357
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@lpinca
lpinca deleted the gh-26357 branch March 6, 2019 06:36
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
@lpinca@BridgeAR
doc: clarify http.Agent constructor options
8b8297d
PR-URL: nodejs#26412Fixes: nodejs#26357
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeARBridgeAR mentioned this pull request Mar 13, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 16, 2019
@lpinca@BethGriggs
doc: clarify http.Agent constructor options
aa49bf5
PR-URL: #26412Fixes: #26357
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BethGriggsBethGriggs mentioned this pull request May 1, 2019
Merged
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott left review comments
@mcollinamcollinamcollina approved these changes
@jasnelljasnelljasnell approved these changes
@BridgeARBridgeARBridgeAR approved these changes
+1 more reviewer
@shisamashisamashisama approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.httpIssues or PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Agent Keep-Alive behavior

7 participants

@lpinca@nodejs-github-bot@BridgeAR@mcollina@jasnell@Trott@shisama