Uh oh!
There was an error while loading. Please reload this page.
test: relax timer check in test-report-uv-handles.js - #26434
Merged
Conversation
richardlau
commented
Mar 4, 2019
MemberAuthor
There was a problem hiding this comment.
Ah I left this in accidentally. I actually think printing the uv handle section of the report is quite useful for debugging failures in this test, so I'm inclined to leave it in unless there are objections.
Contributor
There was a problem hiding this comment.
I don't mind keeping this. It might not be necessary though. If you use any of the report validation functions in test/common/report.js, the full report is printed on failure. That said, if you want to leave this, I'm OK with it.
MemberAuthor
There was a problem hiding this comment.
In #25852 the test was failing before the call to helper.validateContent().
richardlau
commented
Mar 4, 2019
MemberAuthor
cjihrig
approved these changes
Mar 4, 2019
BridgeAR
approved these changes
Mar 4, 2019
MemberAuthor
Resume CI: https://ci.nodejs.org/job/node-test-pull-request/21193/ (✔️) |
addaleax
approved these changes
Mar 4, 2019
lpinca
approved these changes
Mar 4, 2019
gireeshpunathil
approved these changes
Mar 5, 2019
The underlying JavaScript runtime may schedule tasks at its discretion so there may be more timer handles than the one created by the test. PR-URL: nodejs#26434 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
richardlau
commented
Mar 6, 2019
MemberAuthor
Landed in 80209cc |
BridgeAR pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 12, 2019
The underlying JavaScript runtime may schedule tasks at its discretion so there may be more timer handles than the one created by the test. PR-URL: nodejs#26434 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
BridgeAR pushed a commit
that referenced
this pull request
Mar 14, 2019
The underlying JavaScript runtime may schedule tasks at its discretion so there may be more timer handles than the one created by the test. PR-URL: #26434 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The underlying JavaScript runtime may schedule tasks at its discretion
so there may be more timer handles than the one created by the test.
Refs: #25852 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes