Uh oh!
There was an error while loading. Please reload this page.
doc: fix nits in report docs - #26461
Closed
vsemozhetbyt wants to merge 1 commit into
Closed
Conversation
* Fix heading levels. * Fix section sorting. * Add quotes around string values. * Remove quotes around property names.
vsemozhetbyt
commented
Mar 5, 2019
ContributorAuthor
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
addaleax
approved these changes
Mar 5, 2019
cjihrig
approved these changes
Mar 5, 2019
| console.log(`Report directory is ${process.report.directory}`); | ||
| ``` | ||
| ### process.report.filename |
Contributor
There was a problem hiding this comment.
The sad thing is that I tried to put this in the right place but can't alphabet apparently. Sorry
ContributorAuthor
There was a problem hiding this comment.
You've got too much on your plate to be sorry about missing nits))
vsemozhetbyt
commented
Mar 5, 2019
ContributorAuthor
Landed in 60aaf2c |
vsemozhetbyt added a commit
that referenced
this pull request
Mar 5, 2019
* Fix heading levels. * Fix section sorting. * Add quotes around string values. * Remove quotes around property names. PR-URL: #26461 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 12, 2019
* Fix heading levels. * Fix section sorting. * Add quotes around string values. * Remove quotes around property names. PR-URL: nodejs#26461 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Mar 11, 2021
This was referenced May 25, 2021
This was referenced May 25, 2021
This was referenced Apr 7, 2022
This was referenced Jan 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes