http: send connection: close on client error by yannh · Pull Request #26467 · nodejs/node

yannh · 2019-03-06T11:20:17Z

HTTP/1.1 mandates connections which do not support keep-alive and
close the connection send the connection: close header, see
https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.10

This page also provides more information:
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Connection

I understand that HTTP/1.1 defaults to keep-alive - and that the
Connection: close header is required when closing a connection.

This adds the Connection: close header in the 400 and 414
responses sent on client errors.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

HTTP/1.1 mandates connections which do not support keep-alive and close the connection send the connection: close header, see https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.10 This page also provides more information: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Connection I understand that HTTP/1.1 defaults to keep-alive - and that the Connection: close header is required when closing a connection. This adds the Connection: close header in the 400 and 414 responses sent on client errors.

BridgeAR · 2019-03-06T18:28:51Z

CI https://ci.nodejs.org/job/node-test-pull-request/21277/

@nodejs/http PTAL

HTTP/1.1 mandates connections which do not support keep-alive and close the connection send the connection: close header, see https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.10 This page also provides more information: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Connection I understand that HTTP/1.1 defaults to keep-alive - and that the Connection: close header is required when closing a connection. This adds the Connection: close header in the 400 and 414 responses sent on client errors. PR-URL: nodejs#26467 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

BridgeAR · 2019-03-08T23:26:44Z

Landed in c957b05

@yannh congratulations to your first commit to Node.js! 🎉

BridgeAR · 2019-03-12T20:14:23Z

This relies on a semver-major commit. I therefore added the do not land labels.

johanneswuerbach · 2019-03-12T23:18:42Z

@BridgeAR could you elaborate why this is semver-major? I somehow understand that this is a change in behaviour, but on the other hand I think its mainly a bug fix so nodejs is by default adhering to the http 1.1 spec.

lpinca · 2019-03-13T06:08:10Z

@johanneswuerbach because it depends on #25605 which was tagged as semver-major.

johanneswuerbach · 2019-03-13T07:55:38Z

Thanks @lpinca, would you accept a PR targeting 10/11, which only changes this for 400 responses? I’m especially interested in getting this backported into 10 LTS.

Is this something, which node does and if yes, do you have some pointers to how its done? Just cherry-pick parts of this?

lpinca · 2019-03-13T08:03:04Z

Yes, I think we can have a partial backport.

Just cherry-pick parts of this?

Yes.

HTTP/1.1 mandates connections which do not support keep-alive and close the connection send the connection: close header, see https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.10 This page also provides more information: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Connection I understand that HTTP/1.1 defaults to keep-alive - and that the Connection: close header is required when closing a connection. This adds the Connection: close header in the 400 responses sent on client errors. PR-URL: nodejs#26467

johanneswuerbach · 2019-03-13T08:50:03Z

Created a backport for node 10 #26627 / node 11 #26646

HTTP/1.1 mandates connections which do not support keep-alive and close the connection send the connection: close header, see https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.10 This page also provides more information: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Connection I understand that HTTP/1.1 defaults to keep-alive - and that the Connection: close header is required when closing a connection. This adds the Connection: close header in the 400 responses sent on client errors. PR-URL: nodejs#26467

HTTP/1.1 mandates connections which do not support keep-alive and close the connection send the connection: close header, see https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.10 This page also provides more information: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Connection I understand that HTTP/1.1 defaults to keep-alive - and that the Connection: close header is required when closing a connection. This adds the Connection: close header in the 400 responses sent on client errors. PR-URL: #26467 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

HTTP/1.1 mandates connections which do not support keep-alive and close the connection send the connection: close header, see https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.10 This page also provides more information: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Connection I understand that HTTP/1.1 defaults to keep-alive - and that the Connection: close header is required when closing a connection. This adds the Connection: close header in the 400 responses sent on client errors. PR-URL: nodejs#26467 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

HTTP/1.1 mandates connections which do not support keep-alive and close the connection send the connection: close header, see https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.10 This page also provides more information: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Connection I understand that HTTP/1.1 defaults to keep-alive - and that the Connection: close header is required when closing a connection. This adds the Connection: close header in the 400 responses sent on client errors. PR-URL: #26467 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

HTTP/1.1 mandates connections which do not support keep-alive and close the connection send the connection: close header, see https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.10 This page also provides more information: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Connection I understand that HTTP/1.1 defaults to keep-alive - and that the Connection: close header is required when closing a connection. This adds the Connection: close header in the 400 responses sent on client errors. Backport-PR-URL: #26627 PR-URL: #26467 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

nodejs-github-bot added the http Issues or PRs related to the http subsystem. label Mar 6, 2019

mihalskiy approved these changes Mar 6, 2019
View reviewed changes

BridgeAR approved these changes Mar 6, 2019
View reviewed changes

BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 6, 2019

BridgeAR requested a review from lpinca March 6, 2019 18:29

lpinca approved these changes Mar 7, 2019
View reviewed changes

himself65 approved these changes Mar 8, 2019
View reviewed changes

BridgeAR closed this Mar 8, 2019

BridgeAR added dont-land-on-v6.x labels Mar 12, 2019

johanneswuerbach mentioned this pull request Mar 13, 2019
[v10.x backport] http: send connection: close when closing conn #26627
Closed
4 tasks

johanneswuerbach mentioned this pull request Mar 13, 2019
[v11.x backport] http: send connection: close when closing conn #26646
Closed
4 tasks

BridgeAR added backported-to-v10.x and removed dont-land-on-v10.x labels Mar 14, 2019

BridgeAR added backport-requested-v10.x and removed backported-to-v10.x labels Mar 14, 2019

BridgeAR mentioned this pull request Mar 14, 2019
2019-03-14, Version 11.12.0 (Current) #26644
Merged

BridgeAR added backported-to-v11.x and removed backported-to-v11.x labels Mar 14, 2019

BethGriggs mentioned this pull request May 1, 2019
v10.16.0 proposal #27514
Merged

sapphi-red mentioned this pull request May 21, 2026
feat: send 408 on request timeout vitejs/vite#22476
Merged

Navigation Menu

Uh oh!

Uh oh!

http: send connection: close on client error - #26467

http: send connection: close on client error#26467
yannh wants to merge 1 commit into
nodejs:masterfrom
yannh:add_required_header_on_client_error

yannh commented Mar 6, 2019

Uh oh!

BridgeAR commented Mar 6, 2019

Uh oh!

BridgeAR commented Mar 8, 2019

Uh oh!

BridgeAR commented Mar 12, 2019

Uh oh!

johanneswuerbach commented Mar 12, 2019

Uh oh!

lpinca commented Mar 13, 2019

Uh oh!

johanneswuerbach commented Mar 13, 2019

Uh oh!

lpinca commented Mar 13, 2019

Uh oh!

johanneswuerbach commented Mar 13, 2019•
edited
Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Uh oh!

Conversation

yannh commented Mar 6, 2019

Checklist

Uh oh!

BridgeAR commented Mar 6, 2019

Uh oh!

BridgeAR commented Mar 8, 2019

Uh oh!

BridgeAR commented Mar 12, 2019

Uh oh!

johanneswuerbach commented Mar 12, 2019

Uh oh!

lpinca commented Mar 13, 2019

Uh oh!

johanneswuerbach commented Mar 13, 2019

Uh oh!

lpinca commented Mar 13, 2019

Uh oh!

johanneswuerbach commented Mar 13, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

johanneswuerbach commented Mar 13, 2019•
edited
Loading