Skip to content

various cpp improvement in src folder - #26470

Merged
refack merged 1 commit into
nodejs:masterfrom
gengjiawen:19_03_06_misc
Mar 10, 2019
Merged

various cpp improvement in src folder#26470
refack merged 1 commit into
nodejs:masterfrom
gengjiawen:19_03_06_misc

Conversation

@gengjiawen

@gengjiawengengjiawen commented Mar 6, 2019

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Mar 6, 2019
gengjiawen
gengjiawen commented Mar 6, 2019
View reviewed changes
Comment threadsrc/node_api.cc Outdated

@gengjiawengengjiawenMar 6, 2019

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am thinking apply this rule https://clang.llvm.org/extra/clang-tidy/checks/modernize-make-unique.html to whole repo, thoughts ?

cc @addaleax@refack

addaleax
addaleax approved these changes Mar 6, 2019
View reviewed changes
Comment threadsrc/node_api.cc Outdated
@BridgeAR

BridgeAR commented Mar 6, 2019

Copy link
Copy Markdown
Member

CI https://ci.nodejs.org/job/node-test-pull-request/21276/

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 6, 2019
mscdex
mscdex reviewed Mar 6, 2019
View reviewed changes
Comment threadsrc/node_crypto_bio.cc Outdated
@gengjiawengengjiawen changed the title various cpp improment in src foldervarious cpp improvement in src folderMar 7, 2019
@BridgeAR

BridgeAR commented Mar 9, 2019

Copy link
Copy Markdown
Member

CI https://ci.nodejs.org/job/node-test-pull-request/21380/

@refack

refack commented Mar 10, 2019

Copy link
Copy Markdown
Contributor

Resume: https://ci.nodejs.org/job/node-test-commit/26555/

@gengjiawen@refack
src: apply clang-tidy various improvement
6e81a95
* rewrite to default label in method ConvertUVErrorCode
* improve if condition in method PeekWritable
* remove redundant cast in node_file.cc
PR-URL: nodejs#26470
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@refack
refack merged commit 6e81a95 into nodejs:masterMar 10, 2019
@gengjiawen
gengjiawen deleted the 19_03_06_misc branch March 10, 2019 04:29
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
@gengjiawen@BridgeAR
src: apply clang-tidy various improvement
76ecdd4
* rewrite to default label in method ConvertUVErrorCode
* improve if condition in method PeekWritable
* remove redundant cast in node_file.cc
PR-URL: #26470
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
@gengjiawen@BridgeAR
src: apply clang-tidy various improvement
f33163a
* rewrite to default label in method ConvertUVErrorCode
* improve if condition in method PeekWritable
* remove redundant cast in node_file.cc
PR-URL: #26470
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeARBridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@gengjiawen@BridgeAR
src: apply clang-tidy various improvement
a99fb54
* rewrite to default label in method ConvertUVErrorCode
* improve if condition in method PeekWritable
* remove redundant cast in node_file.cc
PR-URL: #26470
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@richardlaurichardlaurichardlau approved these changes
+2 more reviewers
@mscdexmscdexmscdex left review comments
@refackrefackrefack approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@gengjiawen@BridgeAR@refack@mscdex@jasnell@addaleax@richardlau@nodejs-github-bot