test: de-flake test-dns-idna2008.js by refack · Pull Request #26473 · nodejs/node

refack · 2019-03-06T15:31:32Z

Use a known well behaved DNS server.

/CC @nodejs/testing

P.S. ATM the DNS server configured on one of our CI workers, fails for the domain name used in this test:

root@test-rackspace-ubuntu1604-x64-1:~# nslookup xn--strae-oqa.de;; Got SERVFAIL reply from 119.9.60.62, trying next serverServer: 119.9.60.63Address: 119.9.60.63#53** server can't find xn--strae-oqa.de: SERVFAIL

this causes the daily CI test of master to fail: https://ci.nodejs.org/job/node-test-commit-custom-suites/

Lookup works fine when directed to use 8.8.8.8

root@test-rackspace-ubuntu1604-x64-1:~# nslookup xn--strae-oqa.de 8.8.8.8Server: 8.8.8.8Address: 8.8.8.8#53Non-authoritative answer:Name: xn--strae-oqa.deAddress: 81.169.145.78

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

nodejs-github-bot · 2019-03-06T15:31:34Z

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2784/pipeline

refack · 2019-03-06T15:33:12Z

CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/5051/ ✔️

Trott · 2019-03-07T11:27:12Z

Post-adding-comments custom CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/5084/
Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2796/

Trott · 2019-03-07T11:28:26Z

node-daily-master failed today for the sixth day in a row due to this. Would love to fast-track this. 👍 here to fast-track.

EDIT: Withdrawing pending outcome of the "use DNS*_SERVER" conversation. Since node-daily-master only runs once a day, we'll live with the red job another day or two if we have to.

refack · 2019-03-07T22:49:05Z

node-daily-master failed today for the sixth day in a row due to this.

https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/5084/ seems like this doesn't fix the issue 🤔.

Trying again https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/5094/

refack · 2019-03-08T01:27:10Z

The dns.setServers() method affects only dns.resolve(), dns.resolve*() and dns.reverse() (and specifically not dns.lookup()).

So I patched the hardware.

https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/5099/ ✔️
https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/5100/ ✔️

gireeshpunathil · 2019-03-09T14:23:12Z

LGTM!

* use known well-behaved DNS server * force pass on ESERVFAIL PR-URL: nodejs#26473Fixes: nodejs#25870 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Fixes a bug I introduced in 9613221 PR-URL: nodejs#26570 Refs: nodejs#25870 Refs: nodejs#26473 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

* use known well-behaved DNS server * force pass on ESERVFAIL PR-URL: #26473Fixes: #25870 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Fixes a bug I introduced in 9613221 PR-URL: #26570 Refs: #25870 Refs: #26473 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

* use known well-behaved DNS server * force pass on ESERVFAIL PR-URL: #26473Fixes: #25870 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Fixes a bug I introduced in 9613221 PR-URL: #26570 Refs: #25870 Refs: #26473 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Fixes a bug I introduced in 9613221 PR-URL: nodejs#26570 Refs: nodejs#25870 Refs: nodejs#26473 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Fixes a bug I introduced in 9613221 PR-URL: #26570 Refs: #25870 Refs: #26473 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 6, 2019

refack added the dns Issues and PRs related to the dns subsystem. label Mar 6, 2019

refack requested a review from Trott March 6, 2019 15:33

gireeshpunathil approved these changes Mar 6, 2019
View reviewed changes

richardlau reviewed Mar 6, 2019
View reviewed changes

Comment threadtest/internet/test-dns-idna2008.js Outdated

Trott approved these changes Mar 6, 2019
View reviewed changes

Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 7, 2019

Trott added fast-track PRs that do not need to wait for 48 hours to land. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Mar 7, 2019

BridgeAR requested a review from joyeecheung March 7, 2019 13:12

refack self-assigned this Mar 7, 2019

refack force-pushed the fix-idna2008-test branch from 8e7f59c to 7852d68Compare March 7, 2019 22:46

refack force-pushed the fix-idna2008-test branch 3 times, most recently from d2e957e to d9607ddCompare March 9, 2019 00:11

refack requested review from Trott and gireeshpunathil March 9, 2019 14:09

joyeecheung approved these changes Mar 9, 2019
View reviewed changes

test: de-flake test-dns-idna2008.js
9613221
* use known well-behaved DNS server * force pass on ESERVFAIL PR-URL: nodejs#26473Fixes: nodejs#25870 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

refack force-pushed the fix-idna2008-test branch from d9607dd to 9613221Compare March 9, 2019 15:13

refack removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 9, 2019

refack removed the request for review from Trott March 9, 2019 15:13

refack removed the request for review from gireeshpunathil March 9, 2019 15:13

refack merged commit 9613221 into nodejs:masterMar 9, 2019

refack deleted the fix-idna2008-test branch March 9, 2019 15:14

refack mentioned this pull request Mar 10, 2019
test: fix syntax error in test-dns-idna2008.js when failing #26570
Merged
3 tasks

refack removed their assignment Mar 11, 2019

BridgeAR mentioned this pull request Mar 13, 2019
2019-03-14, Version 11.12.0 (Current) #26644
Merged

Navigation Menu

Uh oh!

Uh oh!

test: de-flake test-dns-idna2008.js - #26473

test: de-flake test-dns-idna2008.js#26473
refack merged 1 commit into
nodejs:masterfrom
refack:fix-idna2008-test

refack commented Mar 6, 2019•
edited
Loading

Uh oh!

nodejs-github-bot commented Mar 6, 2019

Uh oh!

refack commented Mar 6, 2019•
edited
Loading

Uh oh!

Uh oh!

Trott commented Mar 7, 2019

Uh oh!

Trott commented Mar 7, 2019•
edited
Loading

Uh oh!

refack commented Mar 7, 2019•
edited
Loading

Uh oh!

refack commented Mar 8, 2019•
edited
Loading

Uh oh!

gireeshpunathil commented Mar 9, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Uh oh!

Conversation

refack commented Mar 6, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

nodejs-github-bot commented Mar 6, 2019

Uh oh!

refack commented Mar 6, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Trott commented Mar 7, 2019

Uh oh!

Trott commented Mar 7, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

refack commented Mar 7, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

refack commented Mar 8, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gireeshpunathil commented Mar 9, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

refack commented Mar 6, 2019•
edited
Loading

refack commented Mar 6, 2019•
edited
Loading

Trott commented Mar 7, 2019•
edited
Loading

refack commented Mar 7, 2019•
edited
Loading

refack commented Mar 8, 2019•
edited
Loading