process: make Symbol.toStringTag writable by BridgeAR · Pull Request #26488 · nodejs/node

BridgeAR · 2019-03-07T10:04:26Z

The ecosystem broke by making it non-writable, so this is a good
intermediate fix.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

The ecosystem broke by making it non-writable, so this is a good intermediate fix.

nodejs-github-bot · 2019-03-07T10:04:28Z

@BridgeAR build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2795/pipeline

BridgeAR · 2019-03-07T10:06:15Z

We could switch this to use getter/setters so we are able to deprecate setting this property as semver-major.

guybedford · 2019-03-07T11:15:20Z

Actually making it a getter so we can deprecate it as major does sound sensible. Especially given Jest already have a fix here. Shall we do a docs-only deprecation here then?

BridgeAR · 2019-03-08T14:56:03Z

~~CI https://ci.nodejs.org/job/node-test-pull-request/21333/~~
CI https://ci.nodejs.org/job/node-test-pull-request/21377/ ✔️

The ecosystem broke by making it non-writable, so this is a good intermediate fix. PR-URL: nodejs#26488 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: James M Snell <jasnell@gmail.com>

BridgeAR · 2019-03-12T19:28:46Z

Landed in 2a7da11 🎉

The ecosystem broke by making it non-writable, so this is a good intermediate fix. PR-URL: #26488 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: James M Snell <jasnell@gmail.com>

Notable Changes * build: * Enable v8's siphash for hash seed creation (Rod Vagg) #26367 * crypto: * Add `KeyObject.asymmetricKeySize` (Patrick Gansterer) #26387 * deps: * Upgrade openssl to 1.1.1b (Sam Roberts) #26327 * process: * Make `process[Symbol.toStringTag]` writable again (Ruben Bridgewater) #26488 * repl: * Add `util.inspect.replDefaults` to customize the writer (Ruben Bridgewater) #26375 * report: * Rename `triggerReport()` to `writeReport()` (Colin Ihrig) #26527

BridgeAR · 2019-03-13T22:21:51Z

@guybedford are you going to open a PR for the deprecation? I personally have no strong opinion about that.

The ecosystem broke by making it non-writable, so this is a good intermediate fix. PR-URL: #26488 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: James M Snell <jasnell@gmail.com>

Notable Changes * bootstrap: * Add experimental `--frozen-intrinsics` flag (Guy Bedford) #25685 * build: * Enable v8's siphash for hash seed creation (Rod Vagg) #26367 * deps: * Upgrade openssl to 1.1.1b (Sam Roberts) #26327 * process: * Make `process[Symbol.toStringTag]` writable again (Ruben Bridgewater) #26488 * repl: * Add `util.inspect.replDefaults` to customize the writer (Ruben Bridgewater) #26375 * report: * Rename `triggerReport()` to `writeReport()` (Colin Ihrig) #26527

guybedford · 2019-03-14T12:46:23Z

@BridgeAR I know it seems small, but intrinsics have non-writeable toStringTags because they are supposed to provide a certain level of consistency so I do think it would be more correct to do this. I don't feel particularly strongly about it either, but will aim to get to the PR as it seems better than not.

The ecosystem broke by making it non-writable, so this is a good intermediate fix. PR-URL: nodejs#26488 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: James M Snell <jasnell@gmail.com>

Notable Changes * bootstrap: * Add experimental `--frozen-intrinsics` flag (Guy Bedford) nodejs#25685 * build: * Enable v8's siphash for hash seed creation (Rod Vagg) nodejs#26367 * deps: * Upgrade openssl to 1.1.1b (Sam Roberts) nodejs#26327 * process: * Make `process[Symbol.toStringTag]` writable again (Ruben Bridgewater) nodejs#26488 * repl: * Add `util.inspect.replDefaults` to customize the writer (Ruben Bridgewater) nodejs#26375 * report: * Rename `triggerReport()` to `writeReport()` (Colin Ihrig) nodejs#26527

The ecosystem broke by making it non-writable, so this is a good intermediate fix. PR-URL: #26488 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: James M Snell <jasnell@gmail.com>

Notable Changes * bootstrap: * Add experimental `--frozen-intrinsics` flag (Guy Bedford) #25685 * build: * Enable v8's siphash for hash seed creation (Rod Vagg) #26367 * deps: * Upgrade openssl to 1.1.1b (Sam Roberts) #26327 * process: * Make `process[Symbol.toStringTag]` writable again (Ruben Bridgewater) #26488 * repl: * Add `util.inspect.replDefaults` to customize the writer (Ruben Bridgewater) #26375 * report: * Rename `triggerReport()` to `writeReport()` (Colin Ihrig) #26527

Notable Changes * bootstrap: * Add experimental `--frozen-intrinsics` flag (Guy Bedford) nodejs#25685 * build: * Enable v8's siphash for hash seed creation (Rod Vagg) nodejs#26367 * deps: * Upgrade openssl to 1.1.1b (Sam Roberts) nodejs#26327 * process: * Make `process[Symbol.toStringTag]` writable again (Ruben Bridgewater) nodejs#26488 * repl: * Add `util.inspect.replDefaults` to customize the writer (Ruben Bridgewater) nodejs#26375 * report: * Rename `triggerReport()` to `writeReport()` (Colin Ihrig) nodejs#26527

process: make Symbol.toStringTag writable
39664bc
The ecosystem broke by making it non-writable, so this is a good intermediate fix.

BridgeAR requested review from addaleax and guybedford March 7, 2019 10:08

SimenB mentioned this pull request Mar 7, 2019
esm: fixup process Proxy to handle toString correctly #25963
Closed
3 tasks

targos approved these changes Mar 7, 2019
View reviewed changes

targos added dont-land-on-v6.x labels Mar 7, 2019

SimenB mentioned this pull request Mar 7, 2019
TypeError: Cannot assign to read only property 'Symbol(Symbol.toStringTag)' of object '#<process>' jestjs/jest#8069
Closed

xxx mentioned this pull request Mar 7, 2019
bump node engine in package.js to be based on 10, the latest LTS CatchRelease/arbor#97
Merged

hiroppy approved these changes Mar 8, 2019
View reviewed changes

hiroppy mentioned this pull request Mar 8, 2019
chore(deps): update jest to v24.3.1 webpack/webpack-dev-server#1704
Merged
6 tasks

jasnell approved these changes Mar 8, 2019
View reviewed changes

BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 8, 2019

richardlau mentioned this pull request Mar 8, 2019
v11.11.0 seems to break entire jest/enzyme test suite #26534
Closed

micalgenus mentioned this pull request Mar 9, 2019
jest error in Node version over 11.11 react/create-react-app#6591
Closed

himself65 approved these changes Mar 9, 2019
View reviewed changes

Hacklor mentioned this pull request Mar 11, 2019
Setting node to version 11.10.1 for Travis philips-software/cogito#100
Merged

BridgeAR closed this Mar 12, 2019

BridgeAR mentioned this pull request Mar 13, 2019
2019-03-14, Version 11.12.0 (Current) #26644
Merged

guybedford mentioned this pull request Mar 17, 2019
process: deprecate toStringTag assignment #26717
Closed
4 tasks

julienw mentioned this pull request Mar 22, 2019
gz test is permafailing on node v11.12.0 firefox-devtools/profiler#1879
Closed

liangchunn mentioned this pull request Mar 25, 2019
Update strip-ansi to the latest version 🚀 liangchunn/typescript-node-scripts#80
Closed

BridgeAR deleted the fix-jest-process-tag branch January 20, 2020 11:55

Navigation Menu

Uh oh!

Uh oh!

process: make Symbol.toStringTag writable - #26488

process: make Symbol.toStringTag writable#26488
BridgeAR wants to merge 1 commit into
nodejs:masterfrom
BridgeAR:fix-jest-process-tag

BridgeAR commented Mar 7, 2019

Uh oh!

nodejs-github-bot commented Mar 7, 2019

Uh oh!

BridgeAR commented Mar 7, 2019

Uh oh!

guybedford commented Mar 7, 2019

Uh oh!

BridgeAR commented Mar 8, 2019•
edited
Loading

Uh oh!

BridgeAR commented Mar 12, 2019

Uh oh!

BridgeAR commented Mar 13, 2019

Uh oh!

guybedford commented Mar 14, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Uh oh!

Conversation

BridgeAR commented Mar 7, 2019

Checklist

Uh oh!

nodejs-github-bot commented Mar 7, 2019

Uh oh!

BridgeAR commented Mar 7, 2019

Uh oh!

guybedford commented Mar 7, 2019

Uh oh!

BridgeAR commented Mar 8, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BridgeAR commented Mar 12, 2019

Uh oh!

BridgeAR commented Mar 13, 2019

Uh oh!

guybedford commented Mar 14, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

BridgeAR commented Mar 8, 2019•
edited
Loading