Skip to content

lib: assign missed deprecation code - #26492

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:dep00125
Closed

lib: assign missed deprecation code#26492
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:dep00125

Conversation

@addaleax

@addaleaxaddaleax commented Mar 7, 2019

Copy link
Copy Markdown
Member

Refs: #26245

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Mar 7, 2019

Copy link
Copy Markdown
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2798/pipeline

@nodejs-github-botnodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label Mar 7, 2019
@addaleax

addaleax commented Mar 7, 2019

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/21300/

Please 👍 this comment to approve fast-tracking.

@addaleaxaddaleax added lib / src Issues and PRs related to general changes in the lib or src directory. fast-track PRs that do not need to wait for 48 hours to land. and removed stream Issues and PRs related to the stream subsystem. labels Mar 7, 2019
@addaleax

addaleax commented Mar 7, 2019

Copy link
Copy Markdown
MemberAuthor

Landed in 76e67e9

@addaleaxaddaleax closed this Mar 7, 2019
@addaleax
addaleax deleted the dep00125 branch March 7, 2019 14:49
addaleax added a commit that referenced this pull request Mar 7, 2019
@addaleax
lib: assign missed deprecation code
76e67e9
Refs: #26245
PR-URL: #26492
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@vsemozhetbytvsemozhetbyt added the deprecations Issues and PRs related to deprecations. label Mar 7, 2019
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrigcjihrigcjihrig approved these changes
@richardlaurichardlaurichardlau approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
@BridgeARBridgeARBridgeAR approved these changes

Assignees

No one assigned

Labels

deprecationsIssues and PRs related to deprecations.fast-trackPRs that do not need to wait for 48 hours to land.lib / srcIssues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@addaleax@nodejs-github-bot@cjihrig@richardlau@gireeshpunathil@BridgeAR@targos@vsemozhetbyt