Skip to content

src: apply clang-tidy rule modernize-make-unique - #26493

Closed
gengjiawen wants to merge 1 commit into
nodejs:masterfrom
gengjiawen:clang-tidy-make-unique
Closed

src: apply clang-tidy rule modernize-make-unique#26493
gengjiawen wants to merge 1 commit into
nodejs:masterfrom
gengjiawen:clang-tidy-make-unique

Conversation

@gengjiawen

@gengjiawengengjiawen commented Mar 7, 2019

Copy link
Copy Markdown
Member

Apply clang-tidy rule https://clang.llvm.org/extra/clang-tidy/checks/modernize-make-unique.html

And also in Item 21: Prefer std::make_unique and std::make_shared to direct use of new.

  • Compared to direct use of new, make functions eliminate source code duplication, improve exception safety, and, for std::make_shared and std::allocate_shared, generate code that’s smaller and faster.
  • Situations where use of make functions is inappropriate include the need to specify custom deleters and a desire to pass braced initializers.

cc @addaleax@refack@bnoordhuis

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Mar 7, 2019
addaleax
addaleax approved these changes Mar 7, 2019
View reviewed changes
Comment threadsrc/node_file.cc Outdated
@gengjiawen
gengjiawenforce-pushed the clang-tidy-make-unique branch from dcbea48 to b4a8d0fCompareMarch 7, 2019 13:47
refack
refack approved these changes Mar 7, 2019
View reviewed changes

@refackrefack left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM % two nits

Comment threadsrc/inspector/main_thread_interface.cc Outdated
Comment threadsrc/inspector/worker_inspector.cc Outdated
@gengjiawen
gengjiawenforce-pushed the clang-tidy-make-unique branch from b4a8d0f to aa2e90cCompareMarch 7, 2019 14:21
bnoordhuis
bnoordhuis approved these changes Mar 7, 2019
View reviewed changes
Comment threadsrc/inspector/main_thread_interface.cc Outdated
Comment threadsrc/inspector/worker_inspector.cc Outdated
Comment threadsrc/inspector/worker_inspector.cc Outdated
@gengjiawen
gengjiawenforce-pushed the clang-tidy-make-unique branch 2 times, most recently from 407a683 to 95e1df2CompareMarch 7, 2019 16:12
@danbev

danbev commented Mar 8, 2019

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/21318/

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 8, 2019
@danbev

danbev commented Mar 12, 2019

Copy link
Copy Markdown
Contributor

@gengjiawen Would you be able to rebase this and fix the conflict reported? Thanks

@gengjiawen

gengjiawen commented Mar 12, 2019

Copy link
Copy Markdown
MemberAuthor

@danbev I can fix this evening :)

@gengjiawen
gengjiawenforce-pushed the clang-tidy-make-unique branch from 95e1df2 to c04401dCompareMarch 12, 2019 14:28
@gengjiawen

gengjiawen commented Mar 12, 2019•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

@danbev done. Can you also help to re-trigger #26496 Jenkins CI ? Thanks.

@danbev

danbev commented Mar 12, 2019

Copy link
Copy Markdown
Contributor

Re-based CI: https://ci.nodejs.org/job/node-test-pull-request/21461/

@gengjiawen
gengjiawenforce-pushed the clang-tidy-make-unique branch from c04401d to 8eefed0CompareMarch 12, 2019 15:14
@gengjiawen

gengjiawen commented Mar 12, 2019

Copy link
Copy Markdown
MemberAuthor

@danbev I forced push because travis-ci found a lint issue ? Do you need to re-trigger this again ? Sorry for this inconvenience.

@BridgeAR

BridgeAR commented Mar 12, 2019•
edited
Loading

Copy link
Copy Markdown
Member

Landed in 575e086 🎉

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
@gengjiawen@BridgeAR
src: apply clang-tidy rule modernize-make-unique
575e086
PR-URL: nodejs#26493
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@BridgeAR

BridgeAR commented Mar 13, 2019

Copy link
Copy Markdown
Member

This does not land cleanly on v11. It seems to rely on other commits (e.g. #26306) that should be backported first. Please open a manual backport for it or change the labels accordingly.

@gengjiawen

gengjiawen commented Mar 13, 2019•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

I am not familiar with backport process, how should I do it ?

@refack

This comment has been minimized.

Sign in to view
@BridgeAR

BridgeAR commented Mar 13, 2019

Copy link
Copy Markdown
Member

If a PR requires manual backports, we should first identify what code it relies upon. There are other PRs that should be backported first as the one that I pointed out. Otherwise there are more conflicts and they become worse over time.

So this one should likely not be the first to be backported. @joyeecheung recently added a tool to node-core-utils that is able to identify them (see https://asciinema.org/a/221244).

A backport itself is just a PR which targets the staging branches of the release line. In this case v11.x-staging instead of master.

@refackrefack mentioned this pull request Mar 14, 2019
Closed
2 tasks
@refack

refack commented Mar 14, 2019

Copy link
Copy Markdown
Contributor

I opened a backport PR for this: #26651

@refackrefack self-assigned this Mar 14, 2019
refack pushed a commit to refack/node that referenced this pull request Mar 14, 2019
@gengjiawen@refack
src: apply clang-tidy rule modernize-make-unique
9b73f1d
PR-URL: nodejs#26493
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
targos pushed a commit that referenced this pull request Mar 28, 2019
@gengjiawen@targos
src: apply clang-tidy rule modernize-make-unique
2a1ce39
PR-URL: #26493
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
targos pushed a commit that referenced this pull request Mar 30, 2019
@gengjiawen@targos
src: apply clang-tidy rule modernize-make-unique
c51cc9e
PR-URL: #26493
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@BethGriggsBethGriggs mentioned this pull request Apr 9, 2019
Merged
@refackrefack removed their assignment Apr 14, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuisbnoordhuisbnoordhuis approved these changes
@addaleaxaddaleaxaddaleax approved these changes
+1 more reviewer
@refackrefackrefack approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@gengjiawen@danbev@BridgeAR@refack@bnoordhuis@addaleax@targos@nodejs-github-bot