Uh oh!
There was an error while loading. Please reload this page.
lib: refactor deprecated function in readline.js - #26494
Closed
gengjiawen wants to merge 1 commit into
Closed
Conversation
BridgeAR
reviewed
Mar 7, 2019
Uh oh!
There was an error while loading. Please reload this page.
gengjiawenforce-pushed
the
rewrite_deprecated_in_readline
branch
from
March 7, 2019 15:41
8fed568 to
e97bac7CompareBridgeAR
reviewed
Mar 7, 2019
Uh oh!
There was an error while loading. Please reload this page.
gengjiawenforce-pushed
the
rewrite_deprecated_in_readline
branch
from
March 7, 2019 15:56
e97bac7 to
1b31834Comparegengjiawenforce-pushed
the
rewrite_deprecated_in_readline
branch
from
March 7, 2019 16:24
1b31834 to
b8b146eCompareBridgeAR
approved these changes
Mar 8, 2019
BridgeAR
commented
Mar 8, 2019
Member
gengjiawen
commented
Mar 10, 2019
MemberAuthor
@BridgeAR I am not quite sure why Jenkins ci failed so many task. Should we re-trigger it ? |
BridgeAR
commented
Mar 10, 2019
Member
@gengjiawen the |
lpinca
approved these changes
Mar 12, 2019
lpinca
commented
Mar 12, 2019
Member
Member
Resumed CI https://ci.nodejs.org/job/node-test-pull-request/21476/ ✔️ |
BridgeAR pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 13, 2019
PR-URL: nodejs#26494 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR
commented
Mar 13, 2019
Member
Landed in b7568e1 🎉 |
BridgeAR pushed a commit
that referenced
this pull request
Mar 14, 2019
PR-URL: #26494 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 14, 2019
PR-URL: nodejs#26494 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR pushed a commit
that referenced
this pull request
Mar 14, 2019
PR-URL: #26494 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes