Skip to content

doc: document fake ENOTFOUND as a system error - #26495

Merged
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:enotfound
Mar 10, 2019
Merged

doc: document fake ENOTFOUND as a system error#26495
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:enotfound

Conversation

@cjihrig

@cjihrigcjihrig commented Mar 7, 2019

Copy link
Copy Markdown
Contributor

Fixes: #26484

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Mar 7, 2019

Copy link
Copy Markdown
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2799/pipeline

@nodejs-github-botnodejs-github-bot added the errors Issues and PRs related to JavaScript errors originated in Node.js core. label Mar 7, 2019
richardlau
richardlau approved these changes Mar 7, 2019
View reviewed changes
Comment threaddoc/api/errors.md Outdated
@BridgeAR

BridgeAR commented Mar 8, 2019

Copy link
Copy Markdown
Member

Lite CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2813/

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 8, 2019
@cjihrig
doc: document fake ENOTFOUND as a system error
3194744
PR-URL: nodejs#26495Fixes: nodejs#26484
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig
cjihrig merged commit 3194744 into nodejs:masterMar 10, 2019
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
@cjihrig@BridgeAR
doc: document fake ENOTFOUND as a system error
7122a3f
PR-URL: #26495Fixes: #26484
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
@cjihrig@BridgeAR
doc: document fake ENOTFOUND as a system error
f91dab6
PR-URL: #26495Fixes: #26484
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeARBridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@cjihrig@BridgeAR
doc: document fake ENOTFOUND as a system error
414ad11
PR-URL: #26495Fixes: #26484
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@TrottTrottTrott approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@gengjiawengengjiawengengjiawen approved these changes
@richardlaurichardlaurichardlau approved these changes
@BridgeARBridgeARBridgeAR approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.errorsIssues and PRs related to JavaScript errors originated in Node.js core.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@cjihrig@nodejs-github-bot@BridgeAR@jasnell@Trott@addaleax@gengjiawen@richardlau