Skip to content

test,doc: add inspector API example for heapdump - #26498

Closed
sam-github wants to merge 1 commit into
nodejs:masterfrom
sam-github:doc-heapdump-example
Closed

test,doc: add inspector API example for heapdump#26498
sam-github wants to merge 1 commit into
nodejs:masterfrom
sam-github:doc-heapdump-example

Conversation

@sam-github

@sam-githubsam-github commented Mar 7, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

cf. nodejs/diagnostics#279

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Mar 7, 2019

Copy link
Copy Markdown
Collaborator

@sam-github build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2801/pipeline

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. inspector Issues and PRs related to the V8 inspector protocol labels Mar 7, 2019
@sam-github

sam-github commented Mar 7, 2019

Copy link
Copy Markdown
ContributorAuthor

ci: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2803/

@eugeneo

eugeneo commented Mar 7, 2019

Copy link
Copy Markdown
Contributor

Would you consider adding a test case that serves as an example but also ensures this documentation is kept in sync with the code changes in the future?

@eugeneoeugeneo closed this Mar 7, 2019
@eugeneoeugeneo reopened this Mar 7, 2019
@sam-github

sam-github commented Mar 7, 2019 via email

Copy link
Copy Markdown
ContributorAuthor

cjihrig
cjihrig approved these changes Mar 7, 2019
View reviewed changes
Comment threaddoc/api/inspector.md Outdated
Comment threaddoc/api/inspector.md Outdated
Comment threaddoc/api/inspector.md Outdated
Comment threaddoc/api/inspector.md Outdated
eugeneo
eugeneo approved these changes Mar 7, 2019
View reviewed changes

@eugeneoeugeneo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

addaleax
addaleax reviewed Mar 7, 2019
View reviewed changes
Comment threaddoc/api/inspector.md Outdated
addaleax
addaleax approved these changes Mar 7, 2019
View reviewed changes
Comment threaddoc/api/inspector.md Outdated
@jasnelljasnell mentioned this pull request Mar 7, 2019
Closed
4 tasks
@BridgeARBridgeAR changed the title doc: add inspector API example for heapdumptest,doc: add inspector API example for heapdumpMar 8, 2019
@BridgeAR

BridgeAR commented Mar 8, 2019

Copy link
Copy Markdown
Member

CI https://ci.nodejs.org/job/node-test-pull-request/21330/

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 8, 2019
@sam-github
sam-githubforce-pushed the doc-heapdump-example branch from 3a31f6d to c75c84dCompareMarch 8, 2019 22:52
@sam-github

sam-github commented Mar 8, 2019

Copy link
Copy Markdown
ContributorAuthor

ci: https://ci.nodejs.org/job/node-test-pull-request/21352/

@sam-github
sam-githubforce-pushed the doc-heapdump-example branch from c75c84d to 02691ceCompareMarch 8, 2019 23:49
@sam-github

sam-github commented Mar 8, 2019

Copy link
Copy Markdown
ContributorAuthor

ci: https://ci.nodejs.org/job/node-test-pull-request/21361/

@danbev

danbev commented Mar 11, 2019

Copy link
Copy Markdown
Contributor

Landed in a445244.

@danbevdanbev closed this Mar 11, 2019
danbev pushed a commit that referenced this pull request Mar 11, 2019
@sam-github@danbev
doc: add inspector API example for heapdump
a445244
PR-URL: #26498
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
@sam-github@BridgeAR
doc: add inspector API example for heapdump
4a72eb3
PR-URL: #26498
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeARBridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@sam-github@BridgeAR
doc: add inspector API example for heapdump
5ad9929
PR-URL: #26498
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@sam-github
sam-github deleted the doc-heapdump-example branch March 20, 2019 15:06
BethGriggs pushed a commit that referenced this pull request Apr 16, 2019
@sam-github@BethGriggs
doc: add inspector API example for heapdump
d4a1d79
PR-URL: #26498
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggsBethGriggs mentioned this pull request May 1, 2019
Merged
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
@fanatidfanatid mentioned this pull request Sep 26, 2019
Closed
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@richardlaurichardlaurichardlau approved these changes
@BridgeARBridgeARBridgeAR approved these changes
+1 more reviewer
@eugeneoeugeneoeugeneo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.inspectorIssues and PRs related to the V8 inspector protocol

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@sam-github@nodejs-github-bot@eugeneo@BridgeAR@danbev@jasnell@addaleax@lpinca@cjihrig@richardlau