Skip to content

process: add --pending-deprecation to process.binding() - #26500

Closed
addaleax wants to merge 3 commits into
nodejs:masterfrom
addaleax:process-binding-pd
Closed

process: add --pending-deprecation to process.binding()#26500
addaleax wants to merge 3 commits into
nodejs:masterfrom
addaleax:process-binding-pd

Conversation

@addaleax

@addaleaxaddaleax commented Mar 7, 2019

Copy link
Copy Markdown
Member

Print a deprecation warning for process.binding() when using
--pending-deprecation.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@addaleax
process: add --pending-deprecation to process.binding()
5be6de9
Print a deprecation warning for `process.binding()` when using
`--pending-deprecation`.
@nodejs-github-bot

nodejs-github-bot commented Mar 7, 2019

Copy link
Copy Markdown
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2804/pipeline

cjihrig
cjihrig approved these changes Mar 7, 2019
View reviewed changes
Comment threadlib/internal/bootstrap/pre_execution.js Outdated
@BridgeAR

BridgeAR commented Mar 8, 2019

Copy link
Copy Markdown
Member

CI https://ci.nodejs.org/job/node-test-pull-request/21331/

@BridgeARBridgeAR added process Issues and PRs related to the process subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Mar 8, 2019
@BridgeAR

BridgeAR commented Mar 8, 2019

Copy link
Copy Markdown
Member

@nodejs/build @nodejs/automation our bot does not seem to detect process related PRs properly (the label is not applied).

tniessen
tniessen approved these changes Mar 8, 2019
View reviewed changes
Comment threaddoc/api/deprecations.md
@addaleax

addaleax commented Mar 8, 2019

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/21336/

@richardlau

richardlau commented Mar 8, 2019

Copy link
Copy Markdown
Member

@nodejs/build @nodejs/automation our bot does not seem to detect process related PRs properly (the label is not applied).

None of the files changed in this PR are exclusive to process though.

@tniessentniessen added the deprecations Issues and PRs related to deprecations. label Mar 8, 2019
@joyeecheung

joyeecheung commented Mar 8, 2019

Copy link
Copy Markdown
Member

None of the files changed in this PR are exclusive to process though.

I guess it should be safe to map lib/internal/bootstrap/* changes to process

ChALkeR
ChALkeR approved these changes Mar 8, 2019
View reviewed changes

@ChALkeRChALkeR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@addaleax

addaleax commented Mar 11, 2019

Copy link
Copy Markdown
MemberAuthor

Landed in 148254744134793cd6556c9749658f3872b03d002

@addaleax
addaleax deleted the process-binding-pd branch March 11, 2019 10:18
addaleax added a commit that referenced this pull request Mar 11, 2019
@addaleax
process: add --pending-deprecation to process.binding()
1482547
Print a deprecation warning for `process.binding()` when using
`--pending-deprecation`.
PR-URL: #26500
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
@addaleax@BridgeAR
process: add --pending-deprecation to process.binding()
9af6631
Print a deprecation warning for `process.binding()` when using
`--pending-deprecation`.
PR-URL: #26500
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@BridgeARBridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@addaleax@BridgeAR
process: add --pending-deprecation to process.binding()
ceebbfb
Print a deprecation warning for `process.binding()` when using
`--pending-deprecation`.
PR-URL: #26500
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChALkeRChALkeRChALkeR approved these changes
@jasnelljasnelljasnell approved these changes
@TrottTrottTrott approved these changes
@targostargostargos approved these changes
@cjihrigcjihrigcjihrig approved these changes
@tniessentniessentniessen approved these changes
@joyeecheungjoyeecheungjoyeecheung approved these changes
@JungMinuJungMinuJungMinu approved these changes
@richardlaurichardlaurichardlau approved these changes
@BridgeARBridgeARBridgeAR approved these changes
+3 more reviewers
@antsmartianantsmartianantsmartian approved these changes
@devsnekdevsnekdevsnek approved these changes
@shisamashisamashisama approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.deprecationsIssues and PRs related to deprecations.processIssues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

15 participants

@addaleax@nodejs-github-bot@BridgeAR@richardlau@joyeecheung@ChALkeR@jasnell@Trott@antsmartian@targos@cjihrig@tniessen@JungMinu@devsnek@shisama