Skip to content

report: fix formatting and add coverage for stdout/stderr - #26522

Merged
cjihrig merged 2 commits into
nodejs:masterfrom
cjihrig:report
Mar 10, 2019
Merged

report: fix formatting and add coverage for stdout/stderr#26522
cjihrig merged 2 commits into
nodejs:masterfrom
cjihrig:report

Conversation

@cjihrig

@cjihrigcjihrig commented Mar 8, 2019

Copy link
Copy Markdown
Contributor

When process.report.filename is 'stdout' or 'stderr', the output runs together. This PR fixes that, and also improves test coverage.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Mar 8, 2019

Copy link
Copy Markdown
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2816/pipeline

@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 8, 2019
@addaleaxaddaleax added the report Issues and PRs related to process.report. label Mar 8, 2019
@BridgeAR

BridgeAR commented Mar 8, 2019•
edited by cjihrig
Loading

Copy link
Copy Markdown
Member

CI https://ci.nodejs.org/job/node-test-pull-request/21349/

EDIT(cjihrig): CI was green.

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 8, 2019
@cjihrig
report: fix stdout/stderr output formatting
24286ea
This commit prevents the report and "report complete" message
from being printed on the same line.
PR-URL: nodejs#26522
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig
test: cover stdout/stderr usage in triggerReport()
86aed6d
This commit adds coverage for the cases where
process.report.filename is 'stdout' or 'stderr'.
PR-URL: nodejs#26522
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig

cjihrig commented Mar 10, 2019

Copy link
Copy Markdown
ContributorAuthor

Landed in 3194744...86aed6d.

@cjihrigcjihrig closed this Mar 10, 2019
@cjihrig
cjihrig deleted the report branch March 10, 2019 19:59
@cjihrig
cjihrig merged commit 86aed6d into nodejs:masterMar 10, 2019
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
@cjihrig@BridgeAR
report: fix stdout/stderr output formatting
541b097
This commit prevents the report and "report complete" message
from being printed on the same line.
PR-URL: #26522
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
@cjihrig@BridgeAR
test: cover stdout/stderr usage in triggerReport()
d6fc9ca
This commit adds coverage for the cases where
process.report.filename is 'stdout' or 'stderr'.
PR-URL: #26522
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
@cjihrig@BridgeAR
report: fix stdout/stderr output formatting
2eb6a40
This commit prevents the report and "report complete" message
from being printed on the same line.
PR-URL: #26522
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
@cjihrig@BridgeAR
test: cover stdout/stderr usage in triggerReport()
b048a38
This commit adds coverage for the cases where
process.report.filename is 'stdout' or 'stderr'.
PR-URL: #26522
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeARBridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@cjihrig@BridgeAR
report: fix stdout/stderr output formatting
ac81fd2
This commit prevents the report and "report complete" message
from being printed on the same line.
PR-URL: #26522
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@cjihrig@BridgeAR
test: cover stdout/stderr usage in triggerReport()
5a0ed0b
This commit adds coverage for the cases where
process.report.filename is 'stdout' or 'stderr'.
PR-URL: #26522
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@richardlaurichardlaurichardlau approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.reportIssues and PRs related to process.report.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cjihrig@nodejs-github-bot@BridgeAR@jasnell@addaleax@richardlau