Skip to content

doc: edit Landing Pull Requests - #26536

Closed
Trott wants to merge 2 commits into
nodejs:masterfrom
Trott:landing-pull-requests
Closed

doc: edit Landing Pull Requests#26536
Trott wants to merge 2 commits into
nodejs:masterfrom
Trott:landing-pull-requests

Conversation

@Trott

@TrottTrott commented Mar 8, 2019

Copy link
Copy Markdown
Member

Edit the Landing Pull Requests section of the Collaborators Guide for
brevity and clarity.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@Trott
doc: edit Landing Pull Requests
ac87744
Edit the Landing Pull Requests section of the Collaborators Guide for
brevity and clarity.
@nodejs-github-bot

nodejs-github-bot commented Mar 8, 2019

Copy link
Copy Markdown
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2828/pipeline

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 8, 2019
@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 8, 2019
@vsemozhetbytvsemozhetbyt added the meta Issues and PRs related to the general management of the project. label Mar 9, 2019
vsemozhetbyt
vsemozhetbyt reviewed Mar 9, 2019
View reviewed changes
Comment threadCOLLABORATOR_GUIDE.md Outdated
vsemozhetbyt
vsemozhetbyt reviewed Mar 9, 2019
View reviewed changes
Comment threadCOLLABORATOR_GUIDE.md Outdated
@Trott

Trott commented Mar 11, 2019

Copy link
Copy Markdown
MemberAuthor

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2857/

@Trott

Trott commented Mar 11, 2019

Copy link
Copy Markdown
MemberAuthor

Landed in cc2c07c

@TrottTrott closed this Mar 11, 2019
Trott added a commit to Trott/io.js that referenced this pull request Mar 11, 2019
@Trott
doc: edit Landing Pull Requests
cc2c07c
Edit the Landing Pull Requests section of the Collaborators Guide for
brevity and clarity.
PR-URL: nodejs#26536
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
@Trott@BridgeAR
doc: edit Landing Pull Requests
e8c45ab
Edit the Landing Pull Requests section of the Collaborators Guide for
brevity and clarity.
PR-URL: #26536
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
@Trott@BridgeAR
doc: edit Landing Pull Requests
119adf2
Edit the Landing Pull Requests section of the Collaborators Guide for
brevity and clarity.
PR-URL: #26536
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeARBridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@Trott@BridgeAR
doc: edit Landing Pull Requests
76c22f8
Edit the Landing Pull Requests section of the Collaborators Guide for
brevity and clarity.
PR-URL: #26536
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 16, 2019
@Trott@BethGriggs
doc: edit Landing Pull Requests
72f0efc
Edit the Landing Pull Requests section of the Collaborators Guide for
brevity and clarity.
PR-URL: #26536
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BethGriggsBethGriggs mentioned this pull request May 1, 2019
Merged
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
@Trott
Trott deleted the landing-pull-requests branch January 13, 2022 22:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targostargostargos approved these changes
@cjihrigcjihrigcjihrig approved these changes
@BridgeARBridgeARBridgeAR approved these changes
+3 more reviewers
@vsemozhetbytvsemozhetbytvsemozhetbyt left review comments
@danbevdanbevdanbev approved these changes
@shisamashisamashisama approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.metaIssues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Trott@nodejs-github-bot@danbev@targos@cjihrig@BridgeAR@shisama@vsemozhetbyt