Skip to content

lib: import TextEncoder and TextDecoder from internal/encoding - #26547

Closed
joyeecheung wants to merge 1 commit into
nodejs:masterfrom
joyeecheung:encoding-require
Closed

lib: import TextEncoder and TextDecoder from internal/encoding#26547
joyeecheung wants to merge 1 commit into
nodejs:masterfrom
joyeecheung:encoding-require

Conversation

@joyeecheung

@joyeecheungjoyeecheung commented Mar 9, 2019

Copy link
Copy Markdown
Member

Refs: #26546

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Mar 9, 2019

Copy link
Copy Markdown
Collaborator

@joyeecheung build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2837/pipeline

@BridgeAR

BridgeAR commented Mar 9, 2019

Copy link
Copy Markdown
Member

CI https://ci.nodejs.org/job/node-test-pull-request/21374/

@BridgeARBridgeAR added lib / src Issues and PRs related to general changes in the lib or src directory. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Mar 9, 2019
@joyeecheung

joyeecheung commented Mar 11, 2019

Copy link
Copy Markdown
MemberAuthor

Resume: https://ci.nodejs.org/job/node-test-pull-request/21437/

@joyeecheung

joyeecheung commented Mar 12, 2019

Copy link
Copy Markdown
MemberAuthor

Landed in 4562697

joyeecheung added a commit that referenced this pull request Mar 12, 2019
@joyeecheung
lib: import TextEncoder and TextDecoder from internal/encoding
4562697
PR-URL: #26547
Refs: #26546
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
@joyeecheung@BridgeAR
lib: import TextEncoder and TextDecoder from internal/encoding
c43e5b3
PR-URL: #26547
Refs: #26546
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeARBridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@joyeecheung@BridgeAR
lib: import TextEncoder and TextDecoder from internal/encoding
f128008
PR-URL: #26547
Refs: #26546
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@joyeecheungjoyeecheung mentioned this pull request Mar 20, 2019
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@targostargostargos approved these changes
@BridgeARBridgeARBridgeAR approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.lib / srcIssues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@joyeecheung@nodejs-github-bot@BridgeAR@jasnell@targos