Skip to content

http: reduce usage of public util - #26548

Closed
ZYSzys wants to merge 1 commit into
nodejs:masterfrom
zys-contrib:util-http
Closed

http: reduce usage of public util#26548
ZYSzys wants to merge 1 commit into
nodejs:masterfrom
zys-contrib:util-http

Conversation

@ZYSzys

@ZYSzysZYSzys commented Mar 9, 2019•
edited
Loading

Copy link
Copy Markdown
Member

Refs: #26546

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the http Issues or PRs related to the http subsystem. label Mar 9, 2019
@BridgeAR

BridgeAR commented Mar 9, 2019

Copy link
Copy Markdown
Member

CI https://ci.nodejs.org/job/node-test-pull-request/21375/

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 9, 2019
@danbev

danbev commented Mar 12, 2019

Copy link
Copy Markdown
Contributor

Landed in 4c4e4f4.

@danbevdanbev closed this Mar 12, 2019
pullBot pushed a commit to Rachelmorrell/node that referenced this pull request Mar 12, 2019
@ZYSzys@danbev
http: reduce usage of public util
4c4e4f4
PR-URL: nodejs#26548
Refs: nodejs#26546
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@ZYSzys
ZYSzys deleted the util-http branch March 12, 2019 05:52
@BridgeAR

BridgeAR commented Mar 13, 2019

Copy link
Copy Markdown
Member

This does not land cleanly on v11. It seems to rely on other commits that should be backported first. Please open a manual backport for it or change the labels accordingly.

@refackrefack mentioned this pull request Mar 14, 2019
Closed
2 tasks
@refack

refack commented Mar 14, 2019

Copy link
Copy Markdown
Contributor

Backport PR: #26650

refack pushed a commit to refack/node that referenced this pull request Mar 14, 2019
@ZYSzys@refack
http: reduce usage of public util
cd77811
PR-URL: nodejs#26548
Refs: nodejs#26546
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@refackrefack self-assigned this Mar 14, 2019
@refackrefack mentioned this pull request Mar 14, 2019
Closed
@joyeecheungjoyeecheung mentioned this pull request Mar 20, 2019
Closed
targos pushed a commit that referenced this pull request Mar 28, 2019
@ZYSzys@targos
http: reduce usage of public util
04441b5
Backport-PR-URL: #26650
PR-URL: #26548
Refs: #26546
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request Mar 30, 2019
@ZYSzys@targos
http: reduce usage of public util
5a29a94
Backport-PR-URL: #26650
PR-URL: #26548
Refs: #26546
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Apr 9, 2019
Merged
@refackrefack removed their assignment Apr 15, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes
@BridgeARBridgeARBridgeAR approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.httpIssues or PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@ZYSzys@BridgeAR@danbev@refack@jasnell@cjihrig@targos@nodejs-github-bot