Skip to content

test: mark test-worker-prof as Flaky on ARM - #26557

Merged
refack merged 1 commit into
nodejs:masterfrom
refack:flake-test-worker-prof
Mar 10, 2019
Merged

test: mark test-worker-prof as Flaky on ARM#26557
refack merged 1 commit into
nodejs:masterfrom
refack:flake-test-worker-prof

Conversation

@refack

@refackrefack commented Mar 10, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Refs: #26401

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Mar 10, 2019

Copy link
Copy Markdown
Collaborator

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2845/pipeline

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Mar 10, 2019
@refack
refack requested review from Trott and addaleaxMarch 10, 2019 02:07
@refackrefack added flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 48 hours to land. labels Mar 10, 2019
@refack

refack commented Mar 10, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

If this passes CI, I move we fast-tack this.
CI: https://ci.nodejs.org/job/node-test-pull-request/21384/

@refack

refack commented Mar 10, 2019

Copy link
Copy Markdown
ContributorAuthor

/CC @nodejs/testing

@refackrefack mentioned this pull request Mar 10, 2019
Closed
@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 10, 2019
@refack
test: mark test-worker-prof as Flaky on ARM
8d665c0
PR-URL: nodejs#26557
Refs: nodejs#26401
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@refack
refackforce-pushed the flake-test-worker-prof branch from 8a690b4 to 8d665c0CompareMarch 10, 2019 14:20
@refack
refack merged commit 8d665c0 into nodejs:masterMar 10, 2019
@refack
refack deleted the flake-test-worker-prof branch March 10, 2019 14:22
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
@refack@BridgeAR
test: mark test-worker-prof as Flaky on ARM
677c43d
PR-URL: #26557
Refs: #26401
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
@refack@BridgeAR
test: mark test-worker-prof as Flaky on ARM
cc32461
PR-URL: #26557
Refs: #26401
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeARBridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@refack@BridgeAR
test: mark test-worker-prof as Flaky on ARM
bf78365
PR-URL: #26557
Refs: #26401
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs pushed a commit that referenced this pull request Apr 16, 2019
@refack@BethGriggs
test: mark test-worker-prof as Flaky on ARM
f0acdfd
PR-URL: #26557
Refs: #26401
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BethGriggsBethGriggs mentioned this pull request May 1, 2019
Merged
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
@BridgeARBridgeARBridgeAR approved these changes
@addaleaxaddaleaxAwaiting requested review from addaleax

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fast-trackPRs that do not need to wait for 48 hours to land.flaky-testIssues and PRs related to the tests with unstable failures on the CI.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@refack@nodejs-github-bot@Trott@gireeshpunathil@BridgeAR