Uh oh!
There was an error while loading. Please reload this page.
src: apply clang-tidy rule modernize-use-emplace - #26564
Closed
gengjiawen wants to merge 1 commit into
Closed
Conversation
BridgeAR
commented
Mar 10, 2019
Member
addaleax
approved these changes
Mar 10, 2019
Uh oh!
There was an error while loading. Please reload this page.
bnoordhuis
approved these changes
Mar 11, 2019
gengjiawenforce-pushed
the
clang-tidy-emplace
branch
2 times, most recently
from
March 11, 2019 14:52
407cfb7 to
f571048Comparejoyeecheung
approved these changes
Mar 12, 2019
danbev
commented
Mar 14, 2019
Contributor
MemberAuthor
danbev
commented
Mar 21, 2019
Contributor
Landed in f091d4e. |
targos
commented
Mar 28, 2019
Member
Compilation fails if this is applied on Please open a backport PR or apply the |
This was referenced Apr 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-emplace.html
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes