Skip to content

doc: edit "Using git-node" section of Guide - #26580

Closed
Trott wants to merge 2 commits into
nodejs:masterfrom
Trott:using-git-node
Closed

doc: edit "Using git-node" section of Guide#26580
Trott wants to merge 2 commits into
nodejs:masterfrom
Trott:using-git-node

Conversation

@Trott

@TrottTrott commented Mar 11, 2019

Copy link
Copy Markdown
Member

Edit the "Using git-node" section of the Collaborator Guide. Make
sentences concise and clear, reduce use of passive voice, etc.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@Trott
doc: edit "Using git-node" section of Guide
be619a8
Edit the "Using git-node" section of the Collaborator Guide. Make
sentences concise and clear, reduce use of passive voice, etc.
@nodejs-github-bot

nodejs-github-bot commented Mar 11, 2019

Copy link
Copy Markdown
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2858/pipeline

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 11, 2019
richardlau
richardlau approved these changes Mar 11, 2019
View reviewed changes
Comment threadCOLLABORATOR_GUIDE.md Outdated
@richardlau@Trott
Update COLLABORATOR_GUIDE.md
576d9bf
Co-Authored-By: Trott <rtrott@gmail.com>
@vsemozhetbytvsemozhetbyt added the meta Issues and PRs related to the general management of the project. label Mar 11, 2019
@vsemozhetbyt

vsemozhetbyt commented Mar 11, 2019

Copy link
Copy Markdown
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbytvsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 11, 2019
@TrottTrott added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 11, 2019
@Trott

Trott commented Mar 11, 2019

Copy link
Copy Markdown
MemberAuthor

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2869/

@Trott

Trott commented Mar 11, 2019

Copy link
Copy Markdown
MemberAuthor

Landed in 2e2670a

@TrottTrott closed this Mar 11, 2019
Trott added a commit to Trott/io.js that referenced this pull request Mar 11, 2019
@Trott
doc: edit "Using git-node" section of Guide
2e2670a
Edit the "Using git-node" section of the Collaborator Guide. Make
sentences concise and clear, reduce use of passive voice, etc.
PR-URL: nodejs#26580
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
@Trott@BridgeAR
doc: edit "Using git-node" section of Guide
98eb711
Edit the "Using git-node" section of the Collaborator Guide. Make
sentences concise and clear, reduce use of passive voice, etc.
PR-URL: #26580
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@BridgeARBridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@Trott@BridgeAR
doc: edit "Using git-node" section of Guide
e2aaee0
Edit the "Using git-node" section of the Collaborator Guide. Make
sentences concise and clear, reduce use of passive voice, etc.
PR-URL: #26580
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
BethGriggs pushed a commit that referenced this pull request Apr 16, 2019
@Trott@BethGriggs
doc: edit "Using git-node" section of Guide
4fed47a
Edit the "Using git-node" section of the Collaborator Guide. Make
sentences concise and clear, reduce use of passive voice, etc.
PR-URL: #26580
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@BethGriggsBethGriggs mentioned this pull request May 1, 2019
Merged
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
@beevelopbeevelop mentioned this pull request May 29, 2019
Closed
@Trott
Trott deleted the using-git-node branch January 13, 2022 22:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrigcjihrigcjihrig approved these changes
@richardlaurichardlaurichardlau approved these changes
@BethGriggsBethGriggsBethGriggs approved these changes
+4 more reviewers
@danbevdanbevdanbev approved these changes
@shisamashisamashisama approved these changes
@vsemozhetbytvsemozhetbytvsemozhetbyt approved these changes
@mihalskiymihalskiymihalskiy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.metaIssues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@Trott@nodejs-github-bot@vsemozhetbyt@danbev@cjihrig@richardlau@BethGriggs@shisama@mihalskiy