Skip to content

doc: add Note of options.stdio into child_process - #26604

Closed
koh110 wants to merge 1 commit into
nodejs:masterfrom
koh110:doc
Closed

doc: add Note of options.stdio into child_process#26604
koh110 wants to merge 1 commit into
nodejs:masterfrom
koh110:doc

Conversation

@koh110

Copy link
Copy Markdown
Contributor

add Note of options.stdio into child_process.

Ref: #22892 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. labels Mar 12, 2019
@koh110

Copy link
Copy Markdown
ContributorAuthor

@addaleax@Trott@bzoz That is a continuation #22892. Would you approve it?

Comment threaddoc/api/child_process.md Outdated

@addaleaxaddaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Comment threaddoc/api/child_process.md Outdated

@bzozbzoz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing file descriptors works fine on Windows, its just sockets that are not supported.

@vsemozhetbytvsemozhetbyt added the windows Issues and PRs related to the Windows platform. label Mar 12, 2019
@koh110

Copy link
Copy Markdown
ContributorAuthor

I see. I think first sentence is better. I thought that file handle and file descriptors are slightly different.
So, I would change Passing sockets does not supported on Windows..
@addaleax@cjihrig@bzoz

@addaleax

Copy link
Copy Markdown
Member

But in that case it’s probably not right to put it just under this particular type of option? Passing in a net.Socket object, rather than a file descriptor, is invalid on Windows too then, right?

Comment threaddoc/api/child_process.md Outdated

@TrottTrottMar 12, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
does not supported on Windows.
is not supported on Windows.

@koh110

Copy link
Copy Markdown
ContributorAuthor

Windows allow named pipe. I think Passing in a net.Socket object is valid on Windows.
But I feel like that file descriptors might be intelligible phrase more than Passing sockets.
Umm...

It's valid on Windows.
https://github.com/nodejs/node/blob/master/test/common/index.js#L176-L181

require('net').createServer((conn) => {
stdio: ['ignore', conn, 'ignore']
});
}).listen(common.PIPE, () => {});

@koh110

Copy link
Copy Markdown
ContributorAuthor

I have no preference. How about this change? @addaleax@cjihrig

@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 16, 2019
@addaleax

Copy link
Copy Markdown
Member

@danbev

Copy link
Copy Markdown
Contributor

Landed in e08ac04.

@danbevdanbev closed this Mar 19, 2019
danbev pushed a commit that referenced this pull request Mar 19, 2019
PR-URL: #26604
Refs: #22892 (comment)
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
PR-URL: nodejs#26604
Refs: nodejs#22892 (comment)
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
targos pushed a commit that referenced this pull request Mar 27, 2019
PR-URL: #26604
Refs: #22892 (comment)
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
@targostargos mentioned this pull request Mar 27, 2019
BethGriggs pushed a commit that referenced this pull request Apr 17, 2019
PR-URL: #26604
Refs: #22892 (comment)
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.child_processIssues and PRs related to the child_process subsystem.docIssues and PRs related to the documentations.windowsIssues and PRs related to the Windows platform.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@koh110@addaleax@danbev@Trott@cjihrig@bzoz@vsemozhetbyt@nodejs-github-bot