Uh oh!
There was an error while loading. Please reload this page.
doc: add Note of options.stdio into child_process - #26604
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
bzoz
left a comment
There was a problem hiding this comment.
Passing file descriptors works fine on Windows, its just sockets that are not supported.
koh110
commented
Mar 12, 2019
addaleax
commented
Mar 12, 2019
But in that case it’s probably not right to put it just under this particular type of option? Passing in a |
There was a problem hiding this comment.
| does not supported on Windows. | |
| is not supported on Windows. |
koh110
commented
Mar 13, 2019
Windows allow named pipe. I think Passing in a It's valid on Windows. |
koh110
commented
Mar 15, 2019
danbev
commented
Mar 19, 2019
Landed in e08ac04. |
PR-URL: #26604 Refs: #22892 (comment) Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
PR-URL: nodejs#26604 Refs: nodejs#22892 (comment) Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
PR-URL: #26604 Refs: #22892 (comment) Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
PR-URL: #26604 Refs: #22892 (comment) Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
PR-URL: #26604 Refs: #22892 (comment) Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
add Note of
options.stdiointo child_process.Ref: #22892 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes