Skip to content

doc: add Gireesh to TSC - #26657

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:add-gireesh-to-tsc
Closed

doc: add Gireesh to TSC#26657
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:add-gireesh-to-tsc

Conversation

@Trott

@TrottTrott commented Mar 14, 2019

Copy link
Copy Markdown
Member

TSC voted in Gireesh today. Add him to the TSC list in the README.

Closes: #26186

@gireeshpunathil

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@Trott
doc: add Gireesh to TSC
63a9b71
TSC voted in Gireesh today. Add him to the TSC list in the README.
Closes: nodejs#26186
@TrottTrott added the notable-change PRs with changes that should be highlighted in changelogs. label Mar 14, 2019
@nodejs-github-bot

nodejs-github-bot commented Mar 14, 2019

Copy link
Copy Markdown
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2904/pipeline

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 14, 2019
@gireeshpunathil

gireeshpunathil commented Mar 14, 2019

Copy link
Copy Markdown
Member

thanks @Trott ! I am not sure if there is any actionable on my part on this PR / any onboarding activity; pls advise!

oliver-gomes
oliver-gomes approved these changes Mar 14, 2019
View reviewed changes

@oliver-gomesoliver-gomes left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well 👍

@Trott

Trott commented Mar 14, 2019

Copy link
Copy Markdown
MemberAuthor

thanks @Trott ! I am not sure if there is any actionable on my part on this PR / any onboarding activity; pls advise!

You can review the PR (confirm the information and formatting is correct) just like any other Collaborator, but other than that, nothing actionable on this PR.

@Trott

Trott commented Mar 14, 2019

Copy link
Copy Markdown
MemberAuthor

Seems no reason to leave this open 48 hours. 👍 here to fast-track.

@TrottTrott added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Mar 14, 2019
@richardlaurichardlau mentioned this pull request Mar 14, 2019
Closed
3 tasks
mhdawson
mhdawson approved these changes Mar 14, 2019
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vsemozhetbytvsemozhetbyt added the meta Issues and PRs related to the general management of the project. label Mar 14, 2019
Trott added a commit to Trott/io.js that referenced this pull request Mar 14, 2019
@Trott
doc: add Gireesh to TSC
8549ac0
TSC voted in Gireesh today. Add him to the TSC list in the README.
Closes: nodejs#26186
PR-URL: nodejs#26657Fixes: nodejs#26186
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@Trott

Trott commented Mar 14, 2019

Copy link
Copy Markdown
MemberAuthor

Landed in 8549ac0

🎉

@TrottTrott closed this Mar 14, 2019
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
@Trott@targos
doc: add Gireesh to TSC
4bb8f6e
TSC voted in Gireesh today. Add him to the TSC list in the README.
Closes: nodejs#26186
PR-URL: nodejs#26657Fixes: nodejs#26186
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
targos pushed a commit that referenced this pull request Mar 27, 2019
@Trott@targos
doc: add Gireesh to TSC
3b471db
TSC voted in Gireesh today. Add him to the TSC list in the README.
Closes: #26186
PR-URL: #26657Fixes: #26186
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
This was referenced Mar 11, 2021
Open
Open
This was referenced May 25, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@Trott
Trott deleted the add-gireesh-to-tsc branch January 13, 2022 22:51
This was referenced Apr 7, 2022
Open
Open
Open
Open
Open
Open
Open
Open
Closed
@snyk-botsnyk-bot mentioned this pull request Jan 30, 2023
Open
@wedataintelligencewedataintelligence mentioned this pull request Jan 30, 2023
Open
@snyk-botsnyk-bot mentioned this pull request Jan 30, 2023
Open
@molllyn1molllyn1 mentioned this pull request Jan 31, 2023
Open
@snyk-botsnyk-bot mentioned this pull request Jan 31, 2023
Open
@baby636baby636 mentioned this pull request Jan 31, 2023
Open
This was referenced Jan 31, 2023
Open
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@targostargostargos approved these changes
@cjihrigcjihrigcjihrig approved these changes
@joyeecheungjoyeecheungjoyeecheung approved these changes
@richardlaurichardlaurichardlau approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
@BethGriggsBethGriggsBethGriggs approved these changes
@BridgeARBridgeARBridgeAR approved these changes
+3 more reviewers
@mhdawsonmhdawsonmhdawson approved these changes
@vsemozhetbytvsemozhetbytvsemozhetbyt approved these changes
@oliver-gomesoliver-gomesoliver-gomes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.metaIssues and PRs related to the general management of the project.notable-changePRs with changes that should be highlighted in changelogs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Nominating Gireesh Punathil (@gireeshpunathil) to the TSC

13 participants

@Trott@nodejs-github-bot@gireeshpunathil@addaleax@targos@cjihrig@joyeecheung@richardlau@BethGriggs@BridgeAR@mhdawson@vsemozhetbyt@oliver-gomes