deps: update V8 to 7.4

[ryzokuken]

ETA: April 23rd, 2019
Intended to supersede #25852

/cc @targos 🎉

[nodejs-github-bot]

@ryzokuken build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2923/pipeline

[ryzokuken]

CI: https://ci.nodejs.org/job/node-test-pull-request/21571/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/2167/

[targos]

/cc @nodejs/v8-update

[addaleax]

@ryzokuken@targos If you want, feel free to include 3ba72b5...51a9301 (v8-7.4 branch on my fork) – all of them are clean cherry-picks of upstream commits, and bring us to API + ABI backwards compatibility with V8 master. I can also push them directly to this branch, if you prefer.

(Adding v8/v8@de7ab39 to that would actually bring us to 1:1 identical APIs, but it’s purely additive and would be just part of a V8 7.5 semver-minor bump on our side.)

CI for those commits: https://ci.nodejs.org/job/node-test-commit/26781/
V8 CI for those commits: https://ci.nodejs.org/job/node-test-commit-v8-linux/2170/

[refack]

@ryzokuken would you consider adding on-behalf-of: @nodejs <about@nodejs.org> to the tail of the first commit message. As per the brand new https://help.github.com/en/articles/creating-a-commit-on-behalf-of-an-organization.

[ryzokuken]

@refack I'd be more than happy to do so. That said, I personally believe it's more suited to the case where commits are made to a repository in org X by a person representing org Y, thus on behalf of the entire organization. For instance, I think upstreaming patches to V8 can be done using this.

Also, I don't think this applies for me anyway:

your commit email and the organization email must be in a domain verified by the organization

[refack]

That said, I personally believe it's more suited to the case where commits are made to a repository in org X by a person representing org Y, thus on behalf of the entire organization. For instance, I think upstreaming patches to V8 can be done using this.

Yeah, it's worth thinking about and discussing some more. As I see it, it's useful as a way to disclaim changes that are not original work by the commiter...

Actually the designation should probably be on-behalf-of: @v8 <about@v8.dev>

[ryzokuken]

Actually the designation should probably be on-behalf-of: @v8about@v8.dev

@refack this sounds much closer to the real situation, and I wholeheartedly agree on discussing it further. For now, I'll add on-behalf-of: @v8 <about@v8.dev> to the commits picked up from V8 directly having no real changes done by us.

[ryzokuken]

BTW, I just realized that the following don't hold up for me:

• you must be a member of the organization indicated in the trailer
• your commit email and the organization email must be in a domain verified by the organization

Because of these, I don't think I can make commits on "behalf of" V8. I will pick this up with the V8 team.

[refack]

Fixes: #26694

[ryzokuken]

@targos@addaleax@refack PTAL.

[targos]

CI: https://ci.nodejs.org/job/node-test-pull-request/21593/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/2173/

[targos]

segfault on LinuxONE. Maybe because of f1d3b41 ?

[targos]

Yeah, we probably need to cherry-pick other commits. There are some with a message like " Prepare for changing kTaggedSize"

[refack]

FYI: I'm strongly considering deprecating the use of pure numbers as values for GYP3 (I want it to be pure strings)...
So in python we might want to use

defb(opt):
return'true'ifoptelse''

this way in the .gyp we can do:

conditions: [
["opt", {}, {}],
["not opt2", {}, {}],
],

but I need to think about this some more.

[refack]

BTW: what the tl;dr about the timeline for landing this?

[targos]

BTW: what the tl;dr about the timeline for landing this?

ASAP to have it in v12 release candidates

[targos]

I cherry-picked all remaining commits related to v8:7703 (and v8/v8@4e6a1a7 to avoid a conflict)

Hopefully we're good: https://ci.nodejs.org/job/node-test-pull-request/21595/

[targos]

Weird, both Windows builders failed git commands.
FreeBSD was disconnected while running tests.

macOS and AIX were already failing before the cherry-picks.
/cc @nodejs/platform-macos @nodejs/platform-aix

[targos]

BTW, this version of V8 breaks our V8-CI because: run-tests.py: error: no such option: --junitout

[refack]

V8-CI issue is nodejs/node-v8#100
Requested a revert in https://chromium-review.googlesource.com/c/v8/v8/+/1430065