Skip to content

lib: lazy load v8 in error-serdes - #26689

Closed
richardlau wants to merge 1 commit into
nodejs:masterfrom
richardlau:lazyv8
Closed

lib: lazy load v8 in error-serdes#26689
richardlau wants to merge 1 commit into
nodejs:masterfrom
richardlau:lazyv8

Conversation

@richardlau

@richardlaurichardlau commented Mar 15, 2019

Copy link
Copy Markdown
Member

Lazy loading v8 in lib/internal/error-serdes.js reduces the number
of loaded modules by the bootstrap code for Worker threads by seven.

Refs: #26501 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@richardlau

This comment has been minimized.

Lazy loading `v8` in `lib/internal/error-serdes.js` reduces the number
of loaded modules by the bootstrap code for Worker threads by seven.
Refs: nodejs#26501 (comment)
@richardlau

Copy link
Copy Markdown
MemberAuthor

@addaleax

Copy link
Copy Markdown
Member

The code LGTM, but it might be worth pointing out that once we have snapshot support, we want as many modules loaded during bootstrap as possible, as opposed to as few as possible.

@richardlau

Copy link
Copy Markdown
MemberAuthor

The code LGTM, but it might be worth pointing out that once we have snapshot support, we want as many modules loaded during bootstrap as possible, as opposed to as few as possible.

I have no objections to closing this if it's not worth it.

@BridgeAR

Copy link
Copy Markdown
Member

@addaleax I would like to experiment with the snapshots as soon as we fully implement them in a way to see what's best. If I am not mistaken we could still have a code cache for the lazy loaded modules which could be a good middle ground for all users.

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 15, 2019
@richardlau

richardlau commented Mar 16, 2019

Copy link
Copy Markdown
MemberAuthor

@danbev

Copy link
Copy Markdown
Contributor

Landed in 927f29d.

@danbevdanbev closed this Mar 19, 2019
pullBot pushed a commit to SimenB/node that referenced this pull request Mar 19, 2019
Lazy loading `v8` in `lib/internal/error-serdes.js` reduces the number
of loaded modules by the bootstrap code for Worker threads by seven.
PR-URL: nodejs#26689
Refs: nodejs#26501 (comment)
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request Mar 27, 2019
Lazy loading `v8` in `lib/internal/error-serdes.js` reduces the number
of loaded modules by the bootstrap code for Worker threads by seven.
PR-URL: #26689
Refs: #26501 (comment)
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targostargos mentioned this pull request Mar 27, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@richardlau@nodejs-github-bot@addaleax@BridgeAR@danbev@jasnell@cjihrig