Skip to content

build: update configure for Node.js 12 - #26719

Merged
richardlau merged 1 commit into
nodejs:masterfrom
richardlau:configure12
Mar 22, 2019
Merged

build: update configure for Node.js 12#26719
richardlau merged 1 commit into
nodejs:masterfrom
richardlau:configure12

Conversation

@richardlau

@richardlaurichardlau commented Mar 17, 2019

Copy link
Copy Markdown
Member

Refs: #26714

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@richardlaurichardlau added the semver-major PRs that contain breaking changes and should be released in the next major version. label Mar 17, 2019
@nodejs-github-bot

nodejs-github-bot commented Mar 17, 2019

Copy link
Copy Markdown
Collaborator

@richardlau build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2944/pipeline

@nodejs-github-botnodejs-github-bot added the build Issues and PRs related to build files or the CI. label Mar 17, 2019
@richardlau

richardlau commented Mar 17, 2019

Copy link
Copy Markdown
MemberAuthor

Note that this check is a warning and doesn't prevent you attempting to use older compilers.

@richardlau

richardlau commented Mar 17, 2019•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/21612/ (✔️)

@mscdex

mscdex commented Mar 17, 2019

Copy link
Copy Markdown
Contributor

If this is just a warning, perhaps the language in the commit message is a bit too strong?

@richardlau

richardlau commented Mar 17, 2019

Copy link
Copy Markdown
MemberAuthor

If this is just a warning, perhaps the language in the commit message is a bit too strong?

¯\_(ツ)_/¯ It's the language we used in previous commits (79773f8, b4f59a7). I used build rather than doc as the subsystem as I felt it's more appropriate).

@refack

refack commented Mar 17, 2019

Copy link
Copy Markdown
Contributor

Note that this check is a warning and doesn't prevent you attempting to use older compilers.

IMHO that makes this not semver-major, just a "don't land on X"

@targos

targos commented Mar 17, 2019

Copy link
Copy Markdown
Member

I agree. #26714 being semver-major is enough

@richardlaurichardlau added dont-land-on-v6.x and removed semver-major PRs that contain breaking changes and should be released in the next major version. labels Mar 17, 2019
refack
refack reviewed Mar 17, 2019
View reviewed changes
Comment threadconfigure.py Outdated
@richardlaurichardlau changed the title build: update configure to require g++ 6.3.0build: update configure for Node.js 12Mar 21, 2019
@richardlau

richardlau commented Mar 21, 2019•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Updated the commit message and clang level. PTAL.

New CI: https://ci.nodejs.org/job/node-test-pull-request/21714/ (✔️)

@richardlaurichardlau mentioned this pull request Mar 21, 2019
Closed
@richardlaurichardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 21, 2019
@refack

refack commented Mar 22, 2019

Copy link
Copy Markdown
Contributor

I think it's good to capture the state of things with this PR right now.
I'm hoping to break everything in #26725 anyway 🤞

@richardlau
build: update configure for Node.js 12
41ba699
Update supported level of gcc to 6.3.0 and clang to 8.0.0.
Refs: nodejs#26714
PR-URL: nodejs#26719
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@richardlau
richardlau merged commit 41ba699 into nodejs:masterMar 22, 2019
@richardlau

richardlau commented Mar 22, 2019

Copy link
Copy Markdown
MemberAuthor

Landed in 41ba699.

This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Oct 21, 2019
Merged
Closed
@richardlaurichardlau mentioned this pull request Nov 8, 2019
Closed
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targostargostargos approved these changes
@BridgeARBridgeARBridgeAR approved these changes
+1 more reviewer
@refackrefackrefack approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.buildIssues and PRs related to build files or the CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@richardlau@nodejs-github-bot@mscdex@refack@targos@BridgeAR