Skip to content

child_process: reduce internal usage of public require of util#26769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
toshi1127 wants to merge 1 commit into from
Closed

child_process: reduce internal usage of public require of util #26769

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions lib/child_process.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,10 +21,13 @@

'use strict';

const util = require('util');
const { convertToValidSignal, getSystemErrorName } = require('internal/util');
const {
promisify,
convertToValidSignal,
getSystemErrorName
} = require('internal/util');
const { isArrayBufferView } = require('internal/util/types');
const debug = util.debuglog('child_process');
const debug = require('internal/util/debuglog').debuglog('child_process');
const { Buffer } = require('buffer');
const { Pipe, constants: PipeConstants } = internalBinding('pipe_wrap');
const {
Expand DownExpand Up@@ -168,7 +171,7 @@ const customPromiseExecFunction = (orig) => {
};
};

Object.defineProperty(exports.exec, util.promisify.custom, {
Object.defineProperty(exports.exec, promisify.custom, {
enumerable: false,
value: customPromiseExecFunction(exports.exec)
});
Expand DownExpand Up@@ -389,7 +392,7 @@ exports.execFile = function execFile(file /* , args, options, callback */) {
return child;
};

Object.defineProperty(exports.execFile, util.promisify.custom, {
Object.defineProperty(exports.execFile, promisify.custom, {
enumerable: false,
value: customPromiseExecFunction(exports.execFile)
});
Expand Down