Skip to content

http.IncomingMessage: fix forgotten 'message' to 'socket' - #2677

Closed
joozek78 wants to merge 1 commit into
nodejs:masterfrom
joozek78:patch-1
Closed

http.IncomingMessage: fix forgotten 'message' to 'socket'#2677
joozek78 wants to merge 1 commit into
nodejs:masterfrom
joozek78:patch-1

Conversation

@joozek78

Copy link
Copy Markdown

No description provided.

@ChALkeRChALkeR added the doc Issues and PRs related to the documentations. label Sep 3, 2015
@mscdex

Copy link
Copy Markdown
Contributor

There's another reference (request.connection) in that same document in http.Server's connection event description. Would you mind changing that as well while we're in there?

@mscdexmscdex added the http Issues or PRs related to the http subsystem. label Sep 3, 2015
@joozek78

Copy link
Copy Markdown
Author

@mscdex Amended

@silverwind

Copy link
Copy Markdown
Contributor

@joozek78 something is wrong with this PR. Could you attempt a rebase or file a new one?

@joozek78

Copy link
Copy Markdown
Author

@silverwind rebased

@jasnell

Copy link
Copy Markdown
Member

LGTM. @silverwind PTAL

@silverwind

Copy link
Copy Markdown
Contributor

What's the reasoning behind this? Are we going to deprecate .connection eventually?

@jasnell

Copy link
Copy Markdown
Member

Actually, looking it over again, I retract my LGTM. Not seeing the reasoning behind this.

@jasnelljasnell added the stalled Issues and PRs that are stalled. label Dec 14, 2015
@silverwind

Copy link
Copy Markdown
Contributor

Closing because of inactivity.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.httpIssues or PRs related to the http subsystem.stalledIssues and PRs that are stalled.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@joozek78@mscdex@silverwind@jasnell@ChALkeR