Skip to content

lib: remove usage of require('util') - #26777

Closed
dnlup wants to merge 1 commit into
nodejs:masterfrom
dnlup:util_internal_console_constructor
Closed

lib: remove usage of require('util')#26777
dnlup wants to merge 1 commit into
nodejs:masterfrom
dnlup:util_internal_console_constructor

Conversation

@dnlup

@dnlupdnlup commented Mar 19, 2019

Copy link
Copy Markdown
Contributor

Remove usage of public require('util').inspect,
require('util').formatWithOptions and require('util').types.

Refs: #26546

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@dnlup
lib: remove usage of require('util')
4a5c9a6
Remove usage of public `require('util').inspect` and `require('util').formatWithOptions`.
Refs: nodejs#26546
@nodejs-github-botnodejs-github-bot added the console Issues and PRs related to the console subsystem. label Mar 19, 2019
@joyeecheungjoyeecheung mentioned this pull request Mar 20, 2019
Closed
@BridgeAR

BridgeAR commented Mar 22, 2019

Copy link
Copy Markdown
Member

CI https://ci.nodejs.org/job/node-test-pull-request/21756/

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 22, 2019
@joyeecheungjoyeecheung mentioned this pull request Mar 22, 2019
Closed
@BridgeAR

BridgeAR commented Mar 22, 2019

Copy link
Copy Markdown
Member

Resumed CI https://ci.nodejs.org/job/node-test-pull-request/21786/

@BridgeAR

BridgeAR commented Mar 24, 2019

Copy link
Copy Markdown
Member

Landed in cf1b9d3 🎉

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 24, 2019
@dnlup@BridgeAR
lib: remove usage of require('util')
cf1b9d3
Remove usage of public `require('util').inspect` and
`require('util').formatWithOptions`.
PR-URL: nodejs#26777
Refs: nodejs#26546
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
@dnlup@targos
lib: remove usage of require('util')
5aa4259
Remove usage of public `require('util').inspect` and
`require('util').formatWithOptions`.
PR-URL: nodejs#26777
Refs: nodejs#26546
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Mar 27, 2019
@dnlup@targos
lib: remove usage of require('util')
64a9229
Remove usage of public `require('util').inspect` and
`require('util').formatWithOptions`.
PR-URL: #26777
Refs: #26546
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Mar 27, 2019
Merged
@dnlup
dnlup deleted the util_internal_console_constructor branch January 10, 2020 13:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@BridgeARBridgeARBridgeAR approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.consoleIssues and PRs related to the console subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dnlup@BridgeAR@jasnell@nodejs-github-bot