Skip to content

fs: reduce usage of require('util') - #26783

Closed
toshi1127 wants to merge 1 commit into
nodejs:masterfrom
toshi1127:util_internal_fs
Closed

fs: reduce usage of require('util')#26783
toshi1127 wants to merge 1 commit into
nodejs:masterfrom
toshi1127:util_internal_fs

Conversation

@toshi1127

@toshi1127toshi1127 commented Mar 19, 2019

Copy link
Copy Markdown
Contributor

Remove the usage of public require('util'), as described in issue:
#26546

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows [commit guidelines]

@nodejs-github-botnodejs-github-bot added the fs Issues and PRs related to the fs subsystem / file system. label Mar 19, 2019
@toshi1127toshi1127 mentioned this pull request Mar 20, 2019
Closed
@BridgeAR

BridgeAR commented Mar 22, 2019

Copy link
Copy Markdown
Member

CI https://ci.nodejs.org/job/node-test-pull-request/21773/

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 22, 2019
@joyeecheungjoyeecheung mentioned this pull request Mar 22, 2019
Closed
@BridgeAR

BridgeAR commented Mar 22, 2019

Copy link
Copy Markdown
Member

Resumed CI https://ci.nodejs.org/job/node-test-pull-request/21790/

@ZYSzys

ZYSzys commented Mar 24, 2019

Copy link
Copy Markdown
Member

@toshi1127 hi, there are some conflicts so we need to rebase this.

@toshi1127

toshi1127 commented Mar 24, 2019

Copy link
Copy Markdown
ContributorAuthor

@ZYSzys
I resolved the conflict !!
Please confirm.

@BridgeAR

BridgeAR commented Mar 24, 2019

Copy link
Copy Markdown
Member

@toshi1127 thanks a lot for following up on the comment! It seems like you used the merge command while we require the plain commits without any merge commits to run our CI. Would you please run git rebase -i upstream/master and git push --force-with-lease afterwards? That removes the merge commit and resolved all conflicts as well.

@BridgeARBridgeAR removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 24, 2019
@toshi1127

toshi1127 commented Mar 25, 2019

Copy link
Copy Markdown
ContributorAuthor

@BridgeAR
@ZYSzys
I resolved the conflict by running git rebase -i upstream / master and git push --force-with-lease.
Please confirm.

@ZYSzys

ZYSzys commented Mar 25, 2019

Copy link
Copy Markdown
Member

new CI: https://ci.nodejs.org/job/node-test-pull-request/21859/

@ZYSzysZYSzys changed the title lib: reduce usage of require('util')fs: reduce usage of require('util')Mar 25, 2019
@ZYSzysZYSzys added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 25, 2019
@ZYSzys

ZYSzys commented Mar 26, 2019

Copy link
Copy Markdown
Member

Landed in 51256e5 🎉🎉

@ZYSzysZYSzys closed this Mar 26, 2019
dnalborczyk pushed a commit to dnalborczyk/node that referenced this pull request Mar 26, 2019
@toshi1127@ZYSzys
fs: reduce usage of require('util')
51256e5
PR-URL: nodejs#26783
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
BethGriggs pushed a commit that referenced this pull request Mar 26, 2019
@toshi1127@BethGriggs
fs: reduce usage of require('util')
5d4c0db
PR-URL: #26783
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
targos pushed a commit that referenced this pull request Mar 28, 2019
@toshi1127@targos
fs: reduce usage of require('util')
07af0f0
PR-URL: #26783
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
targos pushed a commit that referenced this pull request Mar 29, 2019
@toshi1127@targos
fs: reduce usage of require('util')
0da5b7c
PR-URL: #26783
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
targos pushed a commit that referenced this pull request Mar 30, 2019
@toshi1127@targos
fs: reduce usage of require('util')
bb9f1cc
PR-URL: #26783
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Apr 9, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@BridgeARBridgeARBridgeAR approved these changes
@ZYSzysZYSzysZYSzys approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fsIssues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@toshi1127@BridgeAR@ZYSzys@jasnell@nodejs-github-bot