Uh oh!
There was an error while loading. Please reload this page.
http2: reduce usage of public require('util') in core.js - #26789
Closed
Naturalclar wants to merge 2 commits into
Closed
http2: reduce usage of public require('util') in core.js#26789Naturalclar wants to merge 2 commits into
Naturalclar wants to merge 2 commits into
Conversation
shisama
approved these changes
Mar 20, 2019
BridgeAR
approved these changes
Mar 22, 2019
BridgeAR
commented
Mar 22, 2019
Member
BridgeAR
commented
Mar 22, 2019
Member
BridgeAR
commented
Mar 24, 2019
Member
@Naturalclar seems like there are some conflicts. Would you be so kind and rebase this to resolve them and to force push afterwards? Thanks! |
jasnell
approved these changes
Mar 25, 2019
Member
@Naturalclar oh, thanks for your PR first, but I'm sorry to say that this seems to be duplicated with #26784 (which was landed already) |
BridgeAR
commented
Mar 25, 2019
Member
@Naturalclar thanks for the PR and sorry that this can not land. As @ZYSzys pointed out this already landed in Node.js as two PRs were working on the same file. Please keep up the good work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of issue #26546
Replaced usage of public
require('util')Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes