Skip to content

worker: remove usage of require('util') in worker_thread.js - #26814

Closed
toshi1127 wants to merge 1 commit into
nodejs:masterfrom
toshi1127:util_main_worker_thread
Closed

worker: remove usage of require('util') in worker_thread.js#26814
toshi1127 wants to merge 1 commit into
nodejs:masterfrom
toshi1127:util_main_worker_thread

Conversation

@toshi1127

@toshi1127toshi1127 commented Mar 20, 2019

Copy link
Copy Markdown
Contributor

Use require('internal/util/debuglog').debuglog instead of
require('util').debuglog in lib/internal/main/worker_thread.js.

Refs: #26546

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows [commit guidelines]

@joyeecheungjoyeecheung mentioned this pull request Mar 20, 2019
Closed
@BridgeAR

BridgeAR commented Mar 22, 2019

Copy link
Copy Markdown
Member

CI https://ci.nodejs.org/job/node-test-pull-request/21804/

@shisamashisama added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. worker Issues and PRs related to Worker support. labels Mar 24, 2019
@ZYSzys

ZYSzys commented Mar 24, 2019

Copy link
Copy Markdown
Member

Landed in 740e7e8 🎉

@ZYSzysZYSzys closed this Mar 24, 2019
ZYSzys pushed a commit that referenced this pull request Mar 24, 2019
@toshi1127@ZYSzys
worker: remove usage of require('util') in worker_thread.js
740e7e8
PR-URL: #26814
Refs: #26546
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
targos pushed a commit that referenced this pull request Mar 28, 2019
@toshi1127@targos
worker: remove usage of require('util') in worker_thread.js
652e5f8
PR-URL: #26814
Refs: #26546
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
targos pushed a commit that referenced this pull request Mar 30, 2019
@toshi1127@targos
worker: remove usage of require('util') in worker_thread.js
5d9f819
PR-URL: #26814
Refs: #26546
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Apr 9, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@targostargostargos approved these changes
@BridgeARBridgeARBridgeAR approved these changes
@ZYSzysZYSzysZYSzys approved these changes
+1 more reviewer
@shisamashisamashisama approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.workerIssues and PRs related to Worker support.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@toshi1127@BridgeAR@ZYSzys@jasnell@targos@shisama