Uh oh!
There was an error while loading. Please reload this page.
repl: remove usage of require('util') in repl.js - #26820
Closed
dnlup wants to merge 1 commit into
Closed
Conversation
targos
reviewed
Mar 21, 2019
Uh oh!
There was an error while loading. Please reload this page.
BridgeAR
approved these changes
Mar 22, 2019
BridgeAR
commented
Mar 22, 2019
Member
shisama
approved these changes
Mar 22, 2019
shisama
commented
Mar 22, 2019
Contributor
Resume Build: https://ci.nodejs.org/job/node-test-pull-request/21777/ |
jasnell
approved these changes
Mar 22, 2019
BridgeAR
commented
Mar 24, 2019
Member
BridgeAR
commented
Mar 25, 2019
Member
@dnlup this requires a rebase. |
Use `require('internal/util/inspect').inspect` and `require('internal/util/debuglog').debuglog` instead of
`require('util').inspect` and `require('util').debuglog`.
Refs: nodejs#26546ZYSzys
approved these changes
Mar 26, 2019
nodejs-github-bot
commented
Mar 26, 2019
Collaborator
ZYSzys
commented
Mar 29, 2019
Member
Landed in 415a825 🎉 |
ZYSzys pushed a commit
that referenced
this pull request
Mar 29, 2019
Use `require('internal/util/inspect').inspect` and
`require('internal/util/debuglog').debuglog` instead of
`require('util').inspect` and `require('util').debuglog`.
Refs: #26546
PR-URL: #26820
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>BethGriggs pushed a commit
that referenced
this pull request
Apr 5, 2019
Use `require('internal/util/inspect').inspect` and
`require('internal/util/debuglog').debuglog` instead of
`require('util').inspect` and `require('util').debuglog`.
Refs: #26546
PR-URL: #26820
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
This was referenced Apr 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
require('internal/util/inspect').inspectandrequire('internal/util/debuglog').debugloginstead ofrequire('util').inspectandrequire('util').debuglog.Refs: #26546
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes