http2: window size connection control by migounette · Pull Request #26962 · nodejs/node

migounette · 2019-03-28T18:43:12Z

Allow to control the connection window size by setting local window
size (local endpoints's window size) to the given window_size.

To increase window size, this function may submit WINDOW_UPDATE frame
to transmission queue.

Pay attention, this function takes the absolute value of window size to set,
rather than the delta, the delta is computed by the update operation.

Allow to control the connection window size by setting local window size (local endpoints's window size) to the given window_size. To increase window size, this function may submit WINDOW_UPDATE frame to transmission queue. Pay attention, this function takes the absolute value of window size to set, rather than the delta, the delta is computed by the update operation.

BridgeAR · 2019-04-03T01:50:34Z

@nodejs/http2 PTAL

nodejs-github-bot · 2019-04-03T01:51:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/22145/

sebdeckers · 2019-04-12T09:04:34Z

 | `0x0b` | Enhance Your Calm | `http2.constants.NGHTTP2_ENHANCE_YOUR_CALM` |
 | `0x0c` | Inadequate Security | `http2.constants.NGHTTP2_INADEQUATE_SECURITY` |
 | `0x0d` | HTTP/1.1 Required | `http2.constants.NGHTTP2_HTTP_1_1_REQUIRED` |
+| `0x0d` | HTTP/1.1 Required | `http2.constants.NGHTTP2_HTTP_1_1_REQUIRED` |


Duplicate line?

sebdeckers · 2019-04-12T09:09:08Z

+than the delta.
+
+```js
+clientSession.on('connect', (session) => sendSettings(session, (s) => cb(s)));


Perhaps (s) => cb(s) would be more clear, as documentation, if it were written with meaningful variable names (settings?). No need to squeeze it on 80ch; just go multi-line.

jasnell · 2019-04-16T14:37:18Z

+-->
+
+* `windowSize` {number}
+* Returns: 0 


Why return anything?

In fact it's not exaclty the case, at this stage it returns only zero or throws ERR_OUT_OF_RANGE, the function is mapped to nghttp2_session_set_local_window_size.
If the library changes its internal, the value will be returned.
If it does not fit the philosophy of node, we can return a generic errror that maps all errors at the native code level.

mcollina

Would you mind adding a unit test that verifies this behavior?

mcollina · 2019-04-29T15:16:23Z

 the `Http2Session` after `msecs` milliseconds. The given `callback` is
 registered as a listener on the `'timeout'` event.

+#### http2session.setConnectionWindowSize(windowSize)


Would a getter and setter be better for an API?

It's a good point, I am not sure to be able to detect it. There is not acknoledge on a SETTINGS_INITIAL_WINDOW_SIZE
But, we can add a test for testing the limit of the buffer allocation for instance and insure that code results are covered.

I will add the getter

ZYSzys · 2020-01-04T17:07:45Z

Ping @migounette , can you rebase and add some tests so that we can move forward ?

migounette · 2020-01-14T15:16:29Z

Back on tracks for this activity, I will adresse it as soon as possible

HarshithaKP · 2020-04-12T13:21:33Z

@migounette, this needs a rebase.

jasnell · 2020-06-25T14:13:24Z

Unfortunately this work appears to have stalled out. Closing but can reopen if it is picked back up again and rebased.

PR-URL: #35978Fixes: #31084 Refs: #26962 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Mar 28, 2019

migounette mentioned this pull request Mar 28, 2019
http2: allow to control the connection window size #26956
Closed

vsemozhetbyt added the http2 Issues or PRs related to the http2 subsystem. label Mar 28, 2019

sebdeckers reviewed Apr 12, 2019
View reviewed changes

BridgeAR requested review from jasnell and mcollina April 16, 2019 01:53

jasnell reviewed Apr 16, 2019
View reviewed changes

Comment threaddoc/api/http2.md Outdated

jasnell reviewed Apr 16, 2019
View reviewed changes

mcollina requested changes Apr 29, 2019
View reviewed changes

Fix PR lint issues
e38caba

Trott force-pushed the master branch from 1ecc406 to 49cf67eCompare September 17, 2019 16:51

devnexen force-pushed the master branch from e8a4568 to 5289f80Compare December 26, 2019 19:46

ZYSzys mentioned this pull request Jan 4, 2020
http2 - allow option for setting the local window size of a session #31084
Closed

BridgeAR force-pushed the master branch 2 times, most recently from 8ae28ff to 2935f72Compare May 31, 2020 12:19

jasnell added the stalled Issues and PRs that are stalled. label Jun 25, 2020

jasnell closed this Jun 25, 2020

ZYSzys mentioned this pull request Nov 5, 2020
http2: allow setting the local window size of a session #35978
Closed
4 tasks

ZYSzys pushed a commit that referenced this pull request Nov 11, 2020
http2: allow setting the local window size of a session
c0ac692
PR-URL: #35978Fixes: #31084 Refs: #26962 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>

codebytere pushed a commit that referenced this pull request Nov 22, 2020
http2: allow setting the local window size of a session
9c6be3c
PR-URL: #35978Fixes: #31084 Refs: #26962 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>

targos pushed a commit that referenced this pull request Aug 4, 2021
http2: allow setting the local window size of a session
6fd5cd5
PR-URL: #35978Fixes: #31084 Refs: #26962 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>

BethGriggs pushed a commit that referenced this pull request Aug 12, 2021
http2: allow setting the local window size of a session
3533ad5
PR-URL: #35978Fixes: #31084 Refs: #26962 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>

MylesBorins pushed a commit that referenced this pull request Aug 31, 2021
http2: allow setting the local window size of a session
a6c6cbb
PR-URL: #35978Fixes: #31084 Refs: #26962 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>

Uh oh!

Uh oh!

Conversation

migounette commented Mar 28, 2019

Uh oh!

BridgeAR commented Apr 3, 2019

Uh oh!

nodejs-github-bot commented Apr 3, 2019

Uh oh!

sebdeckersApr 12, 2019

Choose a reason for hiding this comment

Uh oh!

sebdeckersApr 12, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jasnellApr 16, 2019

Choose a reason for hiding this comment

Uh oh!

migounetteApr 29, 2019

Choose a reason for hiding this comment

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

mcollinaApr 29, 2019

Choose a reason for hiding this comment

Uh oh!

migounetteApr 29, 2019

Choose a reason for hiding this comment

Uh oh!

migounetteApr 29, 2019

Choose a reason for hiding this comment

Uh oh!

ZYSzys commented Jan 4, 2020

Uh oh!

migounette commented Jan 14, 2020

Uh oh!

HarshithaKP commented Apr 12, 2020

Uh oh!

jasnell commented Jun 25, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants