Skip to content

build,meta: tweak Travis config - #26969

Merged
refack merged 1 commit into
nodejs:masterfrom
refack:travis-tweaks
Apr 2, 2019
Merged

build,meta: tweak Travis config#26969
refack merged 1 commit into
nodejs:masterfrom
refack:travis-tweaks

Conversation

@refack

@refackrefack commented Mar 28, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Mar 28, 2019

Copy link
Copy Markdown
Collaborator

@refack Sadly, an error occurred when I tried to trigger a build. :(

@refack
refack marked this pull request as ready for review March 28, 2019 21:29
richardlau
richardlau reviewed Mar 28, 2019
View reviewed changes
Comment thread.travis.yml Outdated
richardlau
richardlau reviewed Mar 28, 2019
View reviewed changes
Comment thread.travis.yml Outdated
@richardlau

richardlau commented Mar 28, 2019

Copy link
Copy Markdown
Member

Reminder that if you're bumping the gcc version you may have to land in more than one commit to populate the ccache as I had to when we moved to gcc 6 (#26720 (comment)).

@refack

refack commented Mar 28, 2019

Copy link
Copy Markdown
ContributorAuthor

Reminder that if you're bumping the gcc version you may have to land in more than one commit

Mostly wanted to see if this builds faster. Since we might get in the same mess when we land V8 or change INCLUDES in common.gypi...

BTW: https://docs.travis-ci.com/user/caching/#pull-request-builds-and-caches cache lookup and storage is fairly nuanced.

@richardlau

richardlau commented Mar 29, 2019

Copy link
Copy Markdown
Member

Reminder that if you're bumping the gcc version you may have to land in more than one commit

Mostly wanted to see if this builds faster. Since we might get in the same mess when we land V8 or change INCLUDES in common.gypi...

Travis builds are now timing out, which I suspect might be the recent V8 update 😢.

refack
refack commented Mar 29, 2019
View reviewed changes
Comment thread.travis.yml Outdated
@refack

refack commented Mar 30, 2019

Copy link
Copy Markdown
ContributorAuthor

Ok first Travis job passed, so I cleared the cache and restarted.

@refackrefack self-assigned this Mar 30, 2019
@refackrefack added build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. labels Mar 30, 2019
@refack

refack commented Mar 30, 2019

Copy link
Copy Markdown
ContributorAuthor

This is ready for review.

/CC @nodejs/build-files @nodejs/testing

richardlau
richardlau reviewed Mar 30, 2019
View reviewed changes
Comment thread.travis.yml Outdated

@richardlaurichardlauMar 30, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the tap format used by test-ci Travis truncates the log in the web UI. e.g. https://travis-ci.com/nodejs/node/jobs/188985249 so you need to click through to the raw logs to see the full test results.

@refackrefackMar 30, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some grepping to get it down to ~6K lines

Comment thread.travis.yml Outdated
richardlau
richardlau reviewed Mar 30, 2019
View reviewed changes
Comment thread.travis.yml Outdated
richardlau
richardlau approved these changes Mar 30, 2019
View reviewed changes
Comment thread.travis.yml Outdated
@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 1, 2019
@refack

refack commented Apr 1, 2019

Copy link
Copy Markdown
ContributorAuthor

Ping @nodejs/build-files @nodejs/testing

@refack
build,meta: tweak Travis config
7bf5171
* Add `lint-py-build` to get `lint-ci` to lint python
* Add compile V8 job
* Make compilation verbose
* Test with `test-ci`
PR-URL: nodejs#26969
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@refack
refack merged commit 7bf5171 into nodejs:masterApr 2, 2019
BethGriggs pushed a commit that referenced this pull request Apr 5, 2019
@refack@BethGriggs
build,meta: tweak Travis config
c021719
* Add `lint-py-build` to get `lint-ci` to lint python
* Add compile V8 job
* Make compilation verbose
* Test with `test-ci`
PR-URL: #26969
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@refack
refack deleted the travis-tweaks branch April 7, 2019 15:01
BethGriggs pushed a commit that referenced this pull request Apr 9, 2019
@refack@BethGriggs
build,meta: tweak Travis config
a96ad39
* Add `lint-py-build` to get `lint-ci` to lint python
* Add compile V8 job
* Make compilation verbose
* Test with `test-ci`
PR-URL: #26969
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
BethGriggs pushed a commit that referenced this pull request Apr 9, 2019
@refack@BethGriggs
build,meta: tweak Travis config
d8aaf2e
* Add `lint-py-build` to get `lint-ci` to lint python
* Add compile V8 job
* Make compilation verbose
* Test with `test-ci`
PR-URL: #26969
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@BethGriggsBethGriggs mentioned this pull request Apr 9, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 10, 2019
@refack@BethGriggs
build,meta: tweak Travis config
b766c06
* Add `lint-py-build` to get `lint-ci` to lint python
* Add compile V8 job
* Make compilation verbose
* Test with `test-ci`
PR-URL: #26969
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@refackrefack removed their assignment Apr 14, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joyeecheungjoyeecheungjoyeecheung approved these changes
@richardlaurichardlaurichardlau approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.buildIssues and PRs related to build files or the CI.metaIssues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@refack@nodejs-github-bot@richardlau@joyeecheung@BridgeAR