Skip to content

build: run flaky tests in Travis - #27015

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:travis-dont-skip
Closed

build: run flaky tests in Travis#27015
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:travis-dont-skip

Conversation

@addaleax

@addaleaxaddaleax commented Mar 30, 2019•
edited
Loading

Copy link
Copy Markdown
Member

Skipping flaky tests in CI is an anti-pattern that should be avoided,
as we do in our own CI. Failing flaky tests don’t need to be blockers
for a green CI result, but they should be run and reported somehow.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Mar 30, 2019

Copy link
Copy Markdown
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/3109/pipeline

@richardlaurichardlau mentioned this pull request Mar 30, 2019
Closed
2 tasks
@richardlaurichardlau added the build Issues and PRs related to build files or the CI. label Mar 30, 2019
@refackrefack added the blocked PRs that are blocked by other issues or PRs. label Mar 30, 2019
@BridgeAR

BridgeAR commented Mar 31, 2019•
edited
Loading

Copy link
Copy Markdown
Member

@refack can you please elaborate in what way this is blocked and by what?

@addaleax
build: run flaky tests in Travis
44b1fb7
Skipping flaky tests in CI is an anti-pattern that should be avoided,
as we do in our ownCI. Failing flaky tests don’t need to be blockers
for a green CI result, but they should be run and reported *somehow*.
@addaleaxaddaleax removed the blocked PRs that are blocked by other issues or PRs. label Apr 3, 2019
@addaleax

addaleax commented Apr 3, 2019

Copy link
Copy Markdown
MemberAuthor

Rebased, lite CI: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/3152/pipeline

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 4, 2019
@TrottTrott added blocked PRs that are blocked by other issues or PRs. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 5, 2019
@Trott

Trott commented Apr 5, 2019

Copy link
Copy Markdown
Member

Hi, everyone! Sorry to be mysterious, but please leave the blocked label on for another 72 hours. I know we're supposed to provide reasons for things like that and I'm not doing that here. If you could indulge me on this anyway, it would be greatly appreciated.

@TrottTrott mentioned this pull request Apr 9, 2019
Closed
2 tasks
@addaleax

addaleax commented Apr 9, 2019

Copy link
Copy Markdown
MemberAuthor

This PR will continue as #27158. I will not engage in that thread but still stand behind this change.

@addaleaxaddaleax closed this Apr 9, 2019
@addaleax
addaleax deleted the travis-dont-skip branch April 9, 2019 20:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@richardlaurichardlaurichardlau approved these changes
@BridgeARBridgeARBridgeAR approved these changes

Assignees

No one assigned

Labels

blockedPRs that are blocked by other issues or PRs.buildIssues and PRs related to build files or the CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@addaleax@nodejs-github-bot@BridgeAR@Trott@lpinca@richardlau@refack