Uh oh!
There was an error while loading. Please reload this page.
build: only emit download ICU warnings once - #27031
Merged
Merged
Conversation
nodejs-github-bot
commented
Mar 31, 2019
Collaborator
nodejs-github-bot
commented
Mar 31, 2019
Collaborator
nodejs-github-bot
commented
Mar 31, 2019
Collaborator
refack
approved these changes
Mar 31, 2019
refack
commented
Mar 31, 2019
Contributor
/CC @nodejs/build-files @nodejs/python |
BridgeAR
approved these changes
Apr 1, 2019
This was referenced Apr 2, 2019
richardlauforce-pushed
the
downloadwarnings
branch
from
April 3, 2019 21:08
1b407f3 to
0ee6034CompareThe check that the user specified `icu` in `--download` only needs to be done once and not for each entry in `tools/icu/current_ver.dep`. Fixes: nodejs#26860 PR-URL: nodejs#27031 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
richardlauforce-pushed
the
downloadwarnings
branch
from
April 3, 2019 22:56
0ee6034 to
b180a15Comparerichardlau
commented
Apr 3, 2019
MemberAuthor
Landed in b180a15. |
BethGriggs pushed a commit
that referenced
this pull request
Apr 9, 2019
The check that the user specified `icu` in `--download` only needs to be done once and not for each entry in `tools/icu/current_ver.dep`. Fixes: #26860 PR-URL: #27031 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Merged
BethGriggs pushed a commit
that referenced
this pull request
Apr 10, 2019
The check that the user specified `icu` in `--download` only needs to be done once and not for each entry in `tools/icu/current_ver.dep`. Fixes: #26860 PR-URL: #27031 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check that the user specified
icuin--downloadonly needs to bedone once and not for each entry in
tools/icu/current_ver.dep.Fixes: #26860
cc @srl295
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes