Uh oh!
There was an error while loading. Please reload this page.
test: optimize total Travis run time - #27182
Conversation
nodejs-github-bot
commented
Apr 10, 2019
1d940ba to
f3b8644Compare
richardlau
left a comment
There was a problem hiding this comment.
(Ab)using the ccache to transfer binaries between compile and test jobs ✔️💡.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Maybe update the OP? Stages haven't been eliminated. |
9d4dae1 to
92eb382Comparerefack
commented
Apr 11, 2019
Travis run now covers addons as well. minimal time approx 4(compile) + 5.5(test) minutes. |
544a2ff to
2879a5fComparerefack
commented
Apr 12, 2019
@nodejs/testing @nodejs/build-files PTAL |
Uh oh!
There was an error while loading. Please reload this page.
cfeee14 to
d3266fbComparerichardlau
commented
Apr 12, 2019
🤔 https://travis-ci.com/nodejs/node/jobs/192591927 ran 2500 tests. |
Ah it's Lines 502 to 506 in 25df3c1 Lines 472 to 474 in 25df3c1 |
* skip compilation by using cache * split testing into two jobs * DRY with YAML anchors PR-URL: nodejs#27182 Refs: nodejs#27158 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
d3266fb to
8cf3af1Compare



Refs: #27158
Eliminates the stages; they are unnecessary for a typical CI run, and extend the run time by at least 3.5 minutes.Instead of eliminating the compile stage it now caches the binary so the test stage doesn't need to bootstrap the compiler and doesn't need to recompile.
/CC @nodejs/testing @nodejs/build-files @nodejs/python
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes