Uh oh!
There was an error while loading. Please reload this page.
Conversation
refack
commented
Apr 13, 2019
None of those directories should be recreated. Ref: https://github.com/orgs/nodejs/teams/collaborators/discussions/72 |
Uh oh!
There was an error while loading. Please reload this page.
Since there're still many "Debug" and "Release" folders in "deps" and "tools", to make it more strict and totally ignore the generated obj files, ignore all the files/folders under them.
refack
commented
Apr 15, 2019
@Maledong after cleaning those directories are they being created again? Also could you run |
refack
commented
Apr 15, 2019
P.S. Thank you for following up 🎩 |
ghost
commented
Apr 22, 2019
Hi @refack :
Everything seems fine with it now, so nothing is created as expected.
Here's the log for you to see in details: |
ghost
commented
May 8, 2019
Anyone to have a look at this fixture? |
Since there're still many "Debug" and "Release" folders in "deps" and "tools", to make it more strict and totally ignore the generated obj files, ignore all the files/folders under them. Refs: nodejs#27210
addaleax
commented
Jan 29, 2020
I’m closing this as the PR author’s Github user no longer exists and this is being continued in #31565 |
Since there're still many "Debug" and "Release" folders in "deps" and "tools", to make it more strict and totally ignore the generated obj files, ignore all the files/folders under them. Refs: #27210 PR-URL: #31565 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Since there're still many "Debug" and "Release" folders in "deps" and "tools", to make it more strict and totally ignore the generated obj files, ignore all the files/folders under them. Refs: #27210 PR-URL: #31565 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Since there're still many "Debug" and "Release" folders in "deps" and "tools", to make it more strict and totally ignore the generated obj files, ignore all the files/folders under them. Refs: #27210 PR-URL: #31565 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Since there're still many "Debug" and "Release" folders in "deps" and "tools", to make it more strict and totally ignore the generated obj files, ignore all the files/folders under them. Refs: #27210 PR-URL: #31565 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Since there're still many "Debug" and "Release" folders in "deps" and "tools", to make it more strict and totally ignore the generated obj files, ignore all the files/folders under them. Refs: #27210 PR-URL: #31565 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Since there're still many "Debug" and "Release" folders in "deps" and "tools", to make it more strict and totally ignore the generated obj files, ignore all the files/folders under them.
【Before】

【After】
All the "Debug" and "Release" folders are ignored, without changes of tlog and bin files.
make -j4 test(UNIX), orvcbuild test(Windows) passes